Merge pull request #1633 from thiagoandrade6/feature/error-identifier-expected

Add error message IdentifierExpected

Author: felixmulder

src/dotty/tools/dotc/parsing/JavaParsers.scala

@@ -21,6 +21,7 @@ import Symbols._
 import ast.Trees._
 import Decorators._
 import StdNames._
+import dotty.tools.dotc.reporting.diagnostic.messages.IdentifierExpected
 import dotty.tools.dotc.util.SourceFile
 import util.Positions._
 import annotation.switch
@@ -230,7 +231,7 @@ object JavaParsers {
         case AppliedTypeTree(_, _) | Select(_, _) =>
           tree
         case _ =>
-          syntaxError("identifier expected", tree.pos)
+          syntaxError(IdentifierExpected(tree.show), tree.pos)
           errorTypeTree
       }
     }

src/dotty/tools/dotc/parsing/Parsers.scala

@@ -316,7 +316,7 @@ object Parsers {
       case id @ Select(qual, name) =>
         cpy.Select(id)(qual, name.toTypeName)
       case _ =>
-        syntaxError("identifier expected", tree.pos)
+        syntaxError(IdentifierExpected(tree.show), tree.pos)
         tree
     }
 

src/dotty/tools/dotc/reporting/diagnostic/messages.scala

@@ -691,4 +691,28 @@ object messages {
                            |${s"trait A[${mods.flags} type $identifier]"}
                            |""".stripMargin
   }
+
+  case class IdentifierExpected(identifier: String)(implicit ctx: Context) extends Message(25) {
+    val kind = "Syntax"
+
+    val msg = "identifier expected"
+
+    val wrongIdentifier = s"def foo: $identifier = {...}"
+
+    val validIdentifier = s"def foo = {...}"
+
+    val explanation = {
+      hl"""|A valid identifier expected, but `$identifier` found.
+           |Let the compiler infer the type for you.
+           |For example, instead of:
+           |
+           |$wrongIdentifier
+           |
+           |Write your code like:
+           |
+           |$validIdentifier
+           |
+           |""".stripMargin
+    }
+  }
 }