Partially fix #1500: Implicit search breaks at a certain depth #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarter could you have a look? |
|
|
||
| object NatTest { | ||
| def main(args: Array[String]): Unit = { | ||
| assert(implicitly[ToInt[Zero]].value == 0) |
There was a problem hiding this comment.
If you want your assertions to actually be executed, you should put that test in tests/run/, not tests/pos/
|
Otherwise LGTM. |
OlivierBlanvillain
force-pushed
the
fix-1500
branch
from
0032228 to
0f9d084
Compare
| implicit def caseSucc[Prev <: Nat](implicit e: ToInt[Prev]): ToInt[Succ[Prev]] = ToInt(e.value + 1) | ||
| } | ||
|
|
||
| object NatTest { |
There was a problem hiding this comment.
Oops, I forgot to mention that your main class should be called Test to be run.
The issue fixed here was introduced by 71027f1. The added `csyms.isEmpty` condition on `case nil =>` is always true, which is clearely a bug. t1500c still fails with covariant (or contravariant) type parameters on `::`, but this seams to be a more complicated issue involving the typer.
OlivierBlanvillain
force-pushed
the
fix-1500
branch
from
0f9d084 to
fe09615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue fixed here was introduced by 71027f1. The added
csyms.isEmptycondition oncase nil =>is always true, which is clearely a bug.t1500c still fails with covariant (or contravariant) type parameters on
::, but this seams to be a more complicated issue involving the typer.