Skip to content

Typer fixes #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions compiler/src/dotty/tools/dotc/typer/Typer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1517,19 +1517,30 @@ class Typer extends Namer

val seenParents = mutable.Set[Symbol]()

var parentIsEnumClass = false
// Since enums are classes and Namer checks that classes don't extend multiple classes, we can only have one
// violation.
var enumParentOpt: Option[Symbol] = None

def typedParent(tree: untpd.Tree): Tree = {
var result = if (tree.isType) typedType(tree)(superCtx) else typedExpr(tree)(superCtx)
val psym = result.tpe.dealias.typeSymbol
if (seenParents.contains(psym) && !cls.isRefinementClass)
ctx.error(i"$psym is extended twice", tree.pos)
seenParents += psym
if (tree.isType) {
checkSimpleKinded(result) // Not needed for constructor calls, as type arguments will be inferred.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will they be inferred? I'm unconvinced that

class Siz[T](i: Int)
class Zle extends Siz(1)

and

class Siz[T]
class Zle extends Siz

should be treated differently w/r/t superclass targs.

if (psym.is(Trait) && !cls.is(Trait) && !cls.superClass.isSubClass(psym))
result = maybeCall(result, psym, psym.primaryConstructor.info)
}
else checkParentCall(result, cls)
checkTraitInheritance(psym, cls, tree.pos)
if (cls is Case) checkCaseInheritance(psym, cls, tree.pos)
if (psym == defn.EnumClass)
parentIsEnumClass = true
else if (psym.derivesFrom(defn.EnumClass))
enumParentOpt = Some(psym)

result
}

Expand Down Expand Up @@ -1576,6 +1587,12 @@ class Typer extends Namer
if (!cls.is(AbstractOrTrait) && !ctx.isAfterTyper)
checkRealizableBounds(cls, cdef.namePos)
if (cls.is(Case) && cls.derivesFrom(defn.EnumClass)) checkEnum(cdef, cls)
if (parentIsEnumClass) {
for (enumParent <- enumParentOpt)
//Tricky to phrase; language taken from "case-to-case inheritance is prohibited".
ctx.error(s"Enum ${cls.name} has enum ancestor ${enumParent.name}, but enum-to-enum inheritance is prohibited", cdef.pos)
}

val cdef1 = assignType(cpy.TypeDef(cdef)(name, impl1), cls)
if (ctx.phase.isTyper && cdef1.tpe.derivesFrom(defn.DynamicClass) && !ctx.dynamicsEnabled) {
val isRequired = parents1.exists(_.tpe.isRef(defn.DynamicClass))
Expand Down
5 changes: 5 additions & 0 deletions tests/neg/i5008.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
enum Foo { case A }
enum Bar { case A }
enum Baz extends Foo { case Z } // error

enum Quux extends Foo with Bar { case Z } // error
1 change: 1 addition & 0 deletions tests/neg/i5010.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
class i0 extends Function0 // error
2 changes: 0 additions & 2 deletions tests/pending/neg/i5008

This file was deleted.