improvement: Add stack trace to failed results #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
reviewed
Feb 5, 2025
|
We could add both location and stack trace, so that Metals can fill location based on the stack trace, should be a very simple matter of intercepting the message in https://github.com/scalameta/metals/blob/main/metals/src/main/scala/scala/meta/internal/metals/debug/DebugProxy.scala#L275 |
tgodzik
force-pushed
the
add-stacktrace
branch
from
e3224c9 to
1493ca0
Compare
tgodzik
commented
Feb 5, 2025
| val formatted = | ||
| TestSuiteEventHandler.formatError( | ||
| name, | ||
| failedMsg, | ||
| indentSize = 0 | ||
| ) | ||
| SingleTestResult.Failed(name, e.duration, formatted) | ||
| SingleTestResult.Failed(name, e.duration, formatted, stackTrace, location = null) |
There was a problem hiding this comment.
I realized it's gson, so this needs to be null instead of Option
|
I also added the location, so that it's just a case of updating it in Metals |
adpi2
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can later check the first line using existing mechanisms in Metals to get the location