Skip to content

Commit 54f201a

Browse files
committed
Strip new lines in argLine and debugArgLine parameters
1 parent 4afcce5 commit 54f201a

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

src/main/java/org/scalatest/tools/maven/AbstractScalaTestMojo.java

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,7 @@
66
import org.apache.maven.project.MavenProject;
77
import org.codehaus.plexus.util.cli.*;
88

9-
import static java.util.Collections.unmodifiableList;
10-
import static org.scalatest.tools.maven.MojoUtils.*;
11-
12-
import java.io.*;
13-
import java.util.Arrays;
14-
import java.util.Collections;
15-
import java.util.List;
16-
import java.util.ArrayList;
17-
import java.util.Map;
18-
19-
import static java.util.Collections.singletonList;
20-
21-
import java.net.MalformedURLException;
22-
import java.net.URLClassLoader;
23-
import java.net.URL;
9+
import java.io.File;
2410
import java.lang.reflect.InvocationTargetException;
2511
import java.lang.reflect.Method;
2612
import java.net.MalformedURLException;
@@ -29,7 +15,7 @@
2915
import java.util.*;
3016

3117
import static java.util.Collections.singletonList;
32-
import static org.apache.commons.lang3.StringUtils.isEmpty;
18+
import static java.util.Collections.unmodifiableList;
3319
import static org.scalatest.tools.maven.MojoUtils.*;
3420

3521
/**
@@ -294,12 +280,12 @@ private boolean runForkingOnce(String[] args) throws MojoFailureException {
294280

295281
// Set user specified JVM arguments
296282
if (argLine != null) {
297-
cli.createArg().setLine(argLine);
283+
cli.createArg().setLine(stripNewLines(argLine));
298284
}
299285

300286
// Set debugging JVM arguments if debugging is enabled
301287
if (debugForkedProcess) {
302-
cli.createArg().setLine(forkedProcessDebuggingArguments());
288+
cli.createArg().setLine(stripNewLines(forkedProcessDebuggingArguments()));
303289
}
304290

305291
// Set ScalaTest arguments

src/main/java/org/scalatest/tools/maven/MojoUtils.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,4 +147,8 @@ static String getJvm() {
147147
}
148148
return result;
149149
}
150+
151+
static String stripNewLines(String argLine) {
152+
return argLine.replaceAll("[\r\n]{1,2}", " ");
153+
}
150154
}

src/test/scala/org/scalatest/tools/maven/PluginTest.scala

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,4 +208,14 @@ final class PluginTest
208208
MojoUtils.compoundArg("-a", comma("a", "b", "c")) should be(jlist("-a", "a b c"))
209209
MojoUtils.compoundArg("-a", null.asInstanceOf[String]) should be(jlist())
210210
}
211+
212+
def testMojoStripNewLines {
213+
MojoUtils.stripNewLines("-XmsXg -XmxYg -XX:MaxPermSize=Zm") should be("-XmsXg -XmxYg -XX:MaxPermSize=Zm")
214+
MojoUtils.stripNewLines("-XmsXg\n-XmxYg -XX:MaxPermSize=Zm") should be("-XmsXg -XmxYg -XX:MaxPermSize=Zm")
215+
MojoUtils.stripNewLines("-XmsXg\n-XmxYg") should be("-XmsXg -XmxYg")
216+
MojoUtils.stripNewLines("-XmsXg\r-XmxYg -XX:MaxPermSize=Zm") should be("-XmsXg -XmxYg -XX:MaxPermSize=Zm")
217+
MojoUtils.stripNewLines("-XmsXg\r-XmxYg") should be("-XmsXg -XmxYg")
218+
MojoUtils.stripNewLines("-XmsXg\r\n-XmxYg -XX:MaxPermSize=Zm") should be("-XmsXg -XmxYg -XX:MaxPermSize=Zm")
219+
MojoUtils.stripNewLines("-XmsXg\r\n-XmxYg") should be("-XmsXg -XmxYg")
220+
}
211221
}

0 commit comments

Comments
 (0)