Skip to content

Commit e5a21a7

Browse files
committed
Upgraded to selenium-java 4.4.0 and htmlunit-driver 3.64.0, adjusted test code in WebBrowserSpec because htmlunit now follows the behaviour where space key entry is not allowed in email field.
1 parent 8820d4a commit e5a21a7

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

build.sbt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import java.io.PrintWriter
22
import scala.io.Source
33

4-
name := "selenium-4.2"
4+
name := "selenium-4.4"
55

66
organization := "org.scalatestplus"
77

@@ -31,9 +31,9 @@ crossScalaVersions := List("2.10.7", "2.11.12", "2.12.16", "2.13.8", "3.1.3")
3131

3232
libraryDependencies ++= Seq(
3333
"org.scalatest" %% "scalatest-core" % "3.2.13",
34-
"org.seleniumhq.selenium" % "selenium-java" % "4.2.2",
35-
"org.seleniumhq.selenium" % "htmlunit-driver" % "3.62.0",
36-
"org.eclipse.jetty" % "jetty-webapp" % "9.4.44.v20210927" % Test,
34+
"org.seleniumhq.selenium" % "selenium-java" % "4.4.0",
35+
"org.seleniumhq.selenium" % "htmlunit-driver" % "3.64.0",
36+
"org.eclipse.jetty" % "jetty-webapp" % "9.4.48.v20220622" % Test,
3737
"org.scalatest" %% "scalatest-funspec" % "3.2.13" % Test,
3838
"org.scalatest" %% "scalatest-shouldmatchers" % "3.2.13" % Test
3939
)

src/test/scala/org/scalatestplus/selenium/WebBrowserSpec.scala

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,12 @@ trait InputFieldBehaviour extends JettySpec with matchers.should.Matchers with S
144144
fn("secret1").value should be ("")
145145

146146
pressKeys("first secret!")
147-
fn("secret1").value should be ("first secret!")
147+
// Email field won't allow space to be entered by key.
148+
fn("secret1").value should be (if (file == "emailfield.html") "firstsecret!" else "first secret!")
148149
pressKeys(" second secret!")
149-
fn("secret1").value should be ("first secret! second secret!")
150+
fn("secret1").value should be (if (file == "emailfield.html") "firstsecret!secondsecret!" else "first secret! second secret!")
150151
pressKeys(" third secret!")
151-
fn("secret1").value should be ("first secret! second secret! third secret!")
152+
fn("secret1").value should be (if (file == "emailfield.html") "firstsecret!secondsecret!thirdsecret!" else "first secret! second secret! third secret!")
152153
}
153154

154155
}
@@ -906,7 +907,7 @@ class WebBrowserSpec extends JettySpec with matchers.should.Matchers with SpanSu
906907
it should behave like enterField[TelField]("telfield.html", telField _, "TelField", "tel2")
907908
it should behave like enterField[UrlField]("urlfield.html", urlField _, "UrlField", "url2")
908909

909-
it("should allow text to be entered in the active element if it is a email field.") {
910+
it("should allow non-space text to be entered in the active element if it is a email field.") {
910911
go to (host + "emailfield.html")
911912
pageTitle should be ("EmailField")
912913

@@ -921,11 +922,11 @@ class WebBrowserSpec extends JettySpec with matchers.should.Matchers with SpanSu
921922
emailField("secret1").value should be ("")
922923

923924
pressKeys("first secret!")
924-
emailField("secret1").value should be ("first secret!")
925+
emailField("secret1").value should be ("firstsecret!")
925926
pressKeys(" second secret!")
926-
emailField("secret1").value should be ("first secret! second secret!")
927+
emailField("secret1").value should be ("firstsecret!secondsecret!")
927928
pressKeys(" third secret!")
928-
emailField("secret1").value should be ("first secret! second secret! third secret!")
929+
emailField("secret1").value should be ("firstsecret!secondsecret!thirdsecret!")
929930
}
930931

931932
it("should allow text to be entered in the active element if it is a search field.") {
@@ -1332,7 +1333,7 @@ class WebBrowserSpec extends JettySpec with matchers.should.Matchers with SpanSu
13321333
}
13331334

13341335
it("isScreenshotSupported should return false for HtmlUnitDriver") {
1335-
val driver = try new HtmlUnitDriver catch { case e: Throwable => cancel(e) }
1336+
val driver = try new HtmlUnitDriver(true) catch { case e: Throwable => cancel(e) }
13361337
try isScreenshotSupported(driver) should be (false)
13371338
finally close()(driver)
13381339
}

0 commit comments

Comments
 (0)