Skip to content

Commit 230543d

Browse files
committed
fix cassettes + apply review comments
1 parent 9be7c66 commit 230543d

File tree

4 files changed

+5188
-1452
lines changed

4 files changed

+5188
-1452
lines changed

internal/services/rdb/instance.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,6 +667,10 @@ func ResourceRdbInstanceRead(ctx context.Context, d *schema.ResourceData, m inte
667667
_ = d.Set("private_network", pnI)
668668

669669
for _, endpoint := range res.Endpoints {
670+
if endpoint.PrivateNetwork == nil {
671+
continue
672+
}
673+
670674
if endpoint.PrivateNetwork.ProvisioningMode == rdb.EndpointPrivateNetworkDetailsProvisioningModeIpam {
671675
resourceType := ipamAPI.ResourceTypeRdbInstance
672676
opts := &ipam.GetResourcePrivateIPsOptions{
@@ -675,10 +679,12 @@ func ResourceRdbInstanceRead(ctx context.Context, d *schema.ResourceData, m inte
675679
PrivateNetworkID: &res.Endpoints[0].PrivateNetwork.PrivateNetworkID,
676680
}
677681

678-
privateIPs, err = ipam.GetResourcePrivateIPs(ctx, m, region, opts)
682+
endpointPrivateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
679683
if err != nil {
680684
return diag.FromErr(err)
681685
}
686+
687+
privateIPs = append(privateIPs, endpointPrivateIPs...)
682688
}
683689
}
684690
}

internal/services/rdb/testdata/instance-endpoints.cassette.yaml

Lines changed: 2996 additions & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)