chore(container): filterSecretEnvsToPatch is private

Author: Gnoale

internal/services/container/container.go

@@ -397,7 +397,7 @@ func ResourceContainerUpdate(ctx context.Context, d *schema.ResourceData, m inte
 
 	if d.HasChanges("secret_environment_variables") {
 		oldEnv, newEnv := d.GetChange("secret_environment_variables")
-		req.SecretEnvironmentVariables = FilterSecretEnvsToPatch(expandContainerSecrets(oldEnv), expandContainerSecrets(newEnv))
+		req.SecretEnvironmentVariables = filterSecretEnvsToPatch(expandContainerSecrets(oldEnv), expandContainerSecrets(newEnv))
 	}
 
 	if d.HasChanges("min_scale") {

internal/services/container/container_test.go

@@ -13,7 +13,6 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/container"
 	containerchecks "github.com/scaleway/terraform-provider-scaleway/v2/internal/services/container/testfuncs"
-	"github.com/stretchr/testify/assert"
 )
 
 func TestAccContainer_Basic(t *testing.T) {
@@ -629,26 +628,3 @@ func passwordMatchHash(parent string, key string, password string) resource.Test
 		return nil
 	}
 }
-
-func TestFilterSecretEnvsToPatch(t *testing.T) {
-	testSecret := "test_secret"
-	secretToDelete := "secret_to_delete"
-	updatedSecret := "updated_secret"
-	newSecret := "new_secret"
-
-	oldEnv := []*containerSDK.Secret{
-		{Key: testSecret, Value: &testSecret},
-		{Key: secretToDelete, Value: &secretToDelete},
-	}
-	newEnv := []*containerSDK.Secret{
-		{Key: testSecret, Value: &updatedSecret},
-		{Key: newSecret, Value: &newSecret},
-	}
-
-	toPatch := container.FilterSecretEnvsToPatch(oldEnv, newEnv)
-	assert.Equal(t, []*containerSDK.Secret{
-		{Key: testSecret, Value: &updatedSecret},
-		{Key: newSecret, Value: &newSecret},
-		{Key: secretToDelete, Value: nil},
-	}, toPatch)
-}

internal/services/container/helpers_container.go

@@ -373,7 +373,7 @@ func retryCreateContainerDomain(ctx context.Context, containerAPI *container.API
 	}
 }
 
-func FilterSecretEnvsToPatch(oldEnv []*container.Secret, newEnv []*container.Secret) []*container.Secret {
+func filterSecretEnvsToPatch(oldEnv []*container.Secret, newEnv []*container.Secret) []*container.Secret {
 	toPatch := []*container.Secret{}
 	// create and update - ignore hashed values
 	for _, env := range newEnv {

internal/services/container/helpers_container_test.go

@@ -0,0 +1,31 @@
+package container
+
+import (
+	"testing"
+
+	containerSDK "github.com/scaleway/scaleway-sdk-go/api/container/v1beta1"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestFilterSecretEnvsToPatch(t *testing.T) {
+	testSecret := "test_secret"
+	secretToDelete := "secret_to_delete"
+	updatedSecret := "updated_secret"
+	newSecret := "new_secret"
+
+	oldEnv := []*containerSDK.Secret{
+		{Key: testSecret, Value: &testSecret},
+		{Key: secretToDelete, Value: &secretToDelete},
+	}
+	newEnv := []*containerSDK.Secret{
+		{Key: testSecret, Value: &updatedSecret},
+		{Key: newSecret, Value: &newSecret},
+	}
+
+	toPatch := filterSecretEnvsToPatch(oldEnv, newEnv)
+	assert.Equal(t, []*containerSDK.Secret{
+		{Key: testSecret, Value: &updatedSecret},
+		{Key: newSecret, Value: &newSecret},
+		{Key: secretToDelete, Value: nil},
+	}, toPatch)
+}