Skip to content

Commit 9be7c66

Browse files
committed
test + cassettes + linter
1 parent f5e6234 commit 9be7c66

File tree

6 files changed

+357
-2955
lines changed

6 files changed

+357
-2955
lines changed

internal/services/ipam/helpers.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,15 @@ func GetResourcePrivateIPs(ctx context.Context, m interface{}, region scw.Region
8787
if opts.PrivateNetworkID != nil {
8888
req.PrivateNetworkID = opts.PrivateNetworkID
8989
}
90+
9091
if opts.ResourceID != nil {
9192
req.ResourceID = opts.ResourceID
9293
}
94+
9395
if opts.ResourceName != nil {
9496
req.ResourceName = opts.ResourceName
9597
}
98+
9699
if opts.ResourceType != nil {
97100
req.ResourceType = *opts.ResourceType
98101
}
@@ -108,11 +111,13 @@ func GetResourcePrivateIPs(ctx context.Context, m interface{}, region scw.Region
108111
}
109112

110113
ipList := make([]map[string]interface{}, 0, len(resp.IPs))
114+
111115
for _, ip := range resp.IPs {
112116
ipNet := ip.Address
113117
if ipNet.IP == nil {
114118
continue
115119
}
120+
116121
ipMap := map[string]interface{}{
117122
"id": regional.NewIDString(region, ip.ID),
118123
"address": ipNet.IP.String(),

internal/services/ipam/ip_data_source_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,6 @@ func TestAccDataSourceIPAMIP_RDB(t *testing.T) {
151151
user_name = "my_initial_user"
152152
password = "thiZ_is_v&ry_s3cret"
153153
tags = [ "terraform-test", "scaleway_rdb_instance", "volume", "rdb_pn" ]
154-
volume_type = "bssd"
155-
volume_size_in_gb = 10
156154
private_network {
157155
pn_id = "${scaleway_vpc_private_network.main.id}"
158156
enable_ipam = true

0 commit comments

Comments
 (0)