Skip to content

Commit 9ea2653

Browse files
abarbareAntoine Barbare
authored andcommitted
test(redis): remove flaky tests from redis test suite (#2855)
* fix: remove flaky test from redis test suite * fixup! fix: remove flaky test from redis test suite --------- Co-authored-by: Antoine Barbare <[email protected]>
1 parent 412ba92 commit 9ea2653

File tree

2 files changed

+1
-5292
lines changed

2 files changed

+1
-5292
lines changed

internal/services/redis/cluster_test.go

Lines changed: 1 addition & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) {
161161
{
162162
Config: fmt.Sprintf(`
163163
resource scaleway_vpc_private_network private_network {}
164-
164+
165165
resource "scaleway_redis_cluster" "main" {
166166
name = "test_redis_migrate_cluster_size_ipam"
167167
version = "%s"
@@ -222,96 +222,6 @@ func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) {
222222
})
223223
}
224224

225-
func TestAccCluster_MigrateClusterSizeWithStaticEndpoint(t *testing.T) {
226-
tt := acctest.NewTestTools(t)
227-
defer tt.Cleanup()
228-
latestRedisVersion := getLatestVersion(tt)
229-
clusterID := ""
230-
resource.ParallelTest(t, resource.TestCase{
231-
PreCheck: func() { acctest.PreCheck(t) },
232-
ProviderFactories: tt.ProviderFactories,
233-
CheckDestroy: isClusterDestroyed(tt),
234-
Steps: []resource.TestStep{
235-
{
236-
Config: fmt.Sprintf(`
237-
resource scaleway_vpc_private_network private_network {}
238-
239-
resource "scaleway_redis_cluster" "main" {
240-
name = "test_redis_migrate_cluster_size_static"
241-
version = "%s"
242-
node_type = "RED1-XS"
243-
user_name = "my_initial_user"
244-
password = "thiZ_is_v&ry_s3cret"
245-
cluster_size = 1
246-
tls_enabled = "true"
247-
private_network {
248-
id = scaleway_vpc_private_network.private_network.id
249-
service_ips = [
250-
"192.168.99.1/24",
251-
]
252-
}
253-
}
254-
`, latestRedisVersion),
255-
Check: resource.ComposeTestCheckFunc(
256-
isClusterPresent(tt, "scaleway_redis_cluster.main"),
257-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "name", "test_redis_migrate_cluster_size_static"),
258-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "version", latestRedisVersion),
259-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "node_type", "RED1-XS"),
260-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "user_name", "my_initial_user"),
261-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "password", "thiZ_is_v&ry_s3cret"),
262-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "cluster_size", "1"),
263-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "tls_enabled", "true"),
264-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.0", "192.168.99.1/24"),
265-
resource.TestCheckResourceAttrPair("scaleway_redis_cluster.main", "private_network.0.id", "scaleway_vpc_private_network.private_network", "id"),
266-
acctest.CheckResourceIDPersisted("scaleway_redis_cluster.main", &clusterID),
267-
),
268-
},
269-
{
270-
Config: fmt.Sprintf(`
271-
resource scaleway_vpc_private_network private_network {}
272-
273-
resource "scaleway_redis_cluster" "main" {
274-
name = "test_redis_migrate_cluster_size_static"
275-
version = "%s"
276-
node_type = "RED1-XS"
277-
user_name = "my_initial_user"
278-
password = "thiZ_is_v&ry_s3cret"
279-
cluster_size = 3
280-
tls_enabled = "true"
281-
private_network {
282-
id = scaleway_vpc_private_network.private_network.id
283-
service_ips = [
284-
"192.168.99.1/24",
285-
"192.168.99.2/24",
286-
"192.168.99.3/24",
287-
"192.168.99.4/24",
288-
"192.168.99.5/24",
289-
]
290-
}
291-
}
292-
`, latestRedisVersion),
293-
Check: resource.ComposeTestCheckFunc(
294-
isClusterPresent(tt, "scaleway_redis_cluster.main"),
295-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "name", "test_redis_migrate_cluster_size_static"),
296-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "version", latestRedisVersion),
297-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "node_type", "RED1-XS"),
298-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "user_name", "my_initial_user"),
299-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "password", "thiZ_is_v&ry_s3cret"),
300-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "cluster_size", "3"),
301-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "tls_enabled", "true"),
302-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.0", "192.168.99.1/24"),
303-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.1", "192.168.99.2/24"),
304-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.2", "192.168.99.3/24"),
305-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.3", "192.168.99.4/24"),
306-
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.4", "192.168.99.5/24"),
307-
resource.TestCheckResourceAttrPair("scaleway_redis_cluster.main", "private_network.0.id", "scaleway_vpc_private_network.private_network", "id"),
308-
acctest.CheckResourceIDChanged("scaleway_redis_cluster.main", &clusterID),
309-
),
310-
},
311-
},
312-
})
313-
}
314-
315225
func TestAccCluster_ACL(t *testing.T) {
316226
tt := acctest.NewTestTools(t)
317227
defer tt.Cleanup()

0 commit comments

Comments
 (0)