fix: correct logic for RF002 (#409)

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

src/sp_repo_review/checks/ruff.py

@@ -73,9 +73,12 @@ def check(pyproject: dict[str, Any], ruff: dict[str, Any]) -> bool | str:
         """
 
         match pyproject:
+            case {
+                "project": {"requires-python": str()},
+                "tool": {"ruff": {"target-version": object()}},
+            }:
+                return "You have both Ruff's `target-version` and `project.requires-python`. You only need the latter."
             case {"project": {"requires-python": str()}}:
-                if "target-version" in ruff:
-                    return "You have both Ruff's `target-version` and `project.requires-python`. You only need the latter."
                 return True
             case _:
                 return "target-version" in ruff

tests/test_ruff.py

@@ -0,0 +1,33 @@
+from sp_repo_review._compat import tomllib
+from sp_repo_review.checks import ruff
+
+
+def test_rf003_with_rp():
+    toml = tomllib.loads("""
+        project.requires-python = ">=3.12"
+        tool.ruff.anything = "1"
+        """)
+    assert ruff.RF002.check(toml, toml["tool"]["ruff"])
+
+
+def test_rf003_no_rp():
+    toml = tomllib.loads("""
+        project.name = "hi"
+        tool.ruff.target-version = "3.12"
+        """)
+    assert ruff.RF002.check(toml, toml["tool"]["ruff"])
+
+
+def test_rf003_both():
+    toml = tomllib.loads("""
+        project.requires-python = ">=3.12"
+        tool.ruff.target-version = "3.12"
+        """)
+    assert isinstance(ruff.RF002.check(toml, toml["tool"]["ruff"]), str)
+
+
+def test_rf003_split_ok():
+    toml = tomllib.loads("""
+        project.requires-python = ">=3.12"
+        """)
+    assert ruff.RF002.check(toml, {"target-version": "3.12"})