Skip to content

Commit 1ef475b

Browse files
authored
SLEP006: correct terminology use (#66)
Here GroupKFold is the consumer. It knows what `groups` means. The things that provide it with `groups` do not know what `groups` means, only that `GroupKFold` requests it. Hence they are routers.
1 parent 03ef2e4 commit 1ef475b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

slep006/proposal.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ is passed to `LogisticRegressionCV`::
142142
Nested Grouped Cross Validation with SearchCV
143143
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
144144

145-
Since `GroupKFold` requests group metadata by default, `GroupKFold` can be
146-
passed to multiple **consumers** to enable nested grouped cross validation. In
147-
this example, both `RandomizedSearchCV` and `cross_validate` sets
145+
Since `GroupKFold` requests group metadata by default, `GroupKFold` instances can
146+
be passed to multiple **routers** to enable nested grouped cross validation. In
147+
this example, both `RandomizedSearchCV` and `cross_validate` set
148148
`cv=GroupKFold()` which enables grouped CV in the outer loop (`cross_validate`)
149149
and the inner random search::
150150

0 commit comments

Comments
 (0)