Skip to content

Commit 34c18ba

Browse files
Closes #4312
1 parent 809b4bf commit 34c18ba

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

ChangeLog-8.5.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
All notable changes of the PHPUnit 8.5 release series are documented in this file using the [Keep a CHANGELOG](https://keepachangelog.com/) principles.
44

5+
## [8.5.8] - 2020-06-22
6+
7+
### Fixed
8+
9+
* [#4312](https://github.com/sebastianbergmann/phpunit/issues/4312): Fix for [#4299](https://github.com/sebastianbergmann/phpunit/issues/4299) breaks backward compatibility
10+
511
## [8.5.7] - 2020-06-21
612

713
### Fixed
@@ -71,6 +77,7 @@ All notable changes of the PHPUnit 8.5 release series are documented in this fil
7177
* [#3967](https://github.com/sebastianbergmann/phpunit/issues/3967): Cannot double interface that extends interface that extends `\Throwable`
7278
* [#3968](https://github.com/sebastianbergmann/phpunit/pull/3968): Test class run in a separate PHP process are passing when `exit` called inside
7379

80+
[8.5.8]: https://github.com/sebastianbergmann/phpunit/compare/8.5.7...8.5.8
7481
[8.5.7]: https://github.com/sebastianbergmann/phpunit/compare/8.5.6...8.5.7
7582
[8.5.6]: https://github.com/sebastianbergmann/phpunit/compare/8.5.5...8.5.6
7683
[8.5.5]: https://github.com/sebastianbergmann/phpunit/compare/8.5.4...8.5.5

src/Runner/Version.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public static function id(): string
3333
}
3434

3535
if (self::$version === '') {
36-
self::$version = (new VersionId('8.5.7', \dirname(__DIR__, 2)))->getVersion();
36+
self::$version = (new VersionId('8.5.8', \dirname(__DIR__, 2)))->getVersion();
3737
}
3838

3939
return self::$version;

src/TextUI/TestRunner.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -745,10 +745,6 @@ public function doRun(Test $suite, array $arguments = [], array $warnings = [],
745745
}
746746

747747
if ($exit) {
748-
if (\count($result) === 0) {
749-
exit(self::FAILURE_EXIT);
750-
}
751-
752748
if ($result->wasSuccessfulIgnoringWarnings()) {
753749
if ($arguments['failOnRisky'] && !$result->allHarmless()) {
754750
exit(self::FAILURE_EXIT);

0 commit comments

Comments
 (0)