Use Snapshot list helper to avoid possible incomplete migrations

Author: theseer

src/TextUI/XmlConfiguration/Migration/Migrations/MoveWhitelistDirectoriesToCoverage.php

@@ -11,6 +11,7 @@
 
 use DOMDocument;
 use DOMElement;
+use TextUI\XmlConfiguration\Migration\SnapshotNodeList;
 
 /**
  * @internal This class is not covered by the backward compatibility promise for PHPUnit
@@ -37,7 +38,7 @@ public function migrate(DOMDocument $document): void
         $include = $document->createElement('include');
         $coverage->appendChild($include);
 
-        foreach ($whitelist->childNodes as $child) {
+        foreach (SnapshotNodeList::fromNodeList($whitelist->childNodes) as $child) {
             if (!$child instanceof DOMElement || $child->nodeName !== 'directory') {
                 continue;
             }

src/TextUI/XmlConfiguration/Migration/Migrations/RemoveLogTypes.php

@@ -11,6 +11,7 @@
 
 use DOMDocument;
 use DOMElement;
+use TextUI\XmlConfiguration\Migration\SnapshotNodeList;
 
 /**
  * @internal This class is not covered by the backward compatibility promise for PHPUnit
@@ -25,7 +26,7 @@ public function migrate(DOMDocument $document): void
             return;
         }
 
-        foreach ($logging->getElementsByTagName('log') as $logNode) {
+        foreach (SnapshotNodeList::fromNodeList($logging->getElementsByTagName('log')) as $logNode) {
             switch ($logNode->getAttribute('type')) {
                 case 'json':
                 case 'tap':