fix: add warnings when the date format does not parse (#748)

Author: oscb

packages/plugins/plugin-braze/src/BrazePlugin.tsx

@@ -5,9 +5,12 @@ import {
   TrackEventType,
   UserInfoState,
 } from '@segment/analytics-react-native';
-import identify from './methods/identify';
-import track from './methods/track';
+import ReactAppboy, {
+  GenderTypes,
+  MonthsAsNumber,
+} from 'react-native-appboy-sdk';
 import flush from './methods/flush';
+import track from './methods/track';
 
 export class BrazePlugin extends DestinationPlugin {
   type = PluginType.destination;
@@ -24,7 +27,82 @@ export class BrazePlugin extends DestinationPlugin {
     ) {
       return;
     } else {
-      identify(event);
+      if (event.userId) {
+        ReactAppboy.changeUser(event.userId);
+      }
+
+      if (event.traits?.birthday !== undefined) {
+        const birthday = new Date(event.traits.birthday);
+        if (
+          birthday !== undefined &&
+          birthday !== null &&
+          !isNaN(birthday.getTime())
+        ) {
+          const data = new Date(event.traits.birthday);
+          ReactAppboy.setDateOfBirth(
+            data.getFullYear(),
+            // getMonth is zero indexed
+            (data.getMonth() + 1) as MonthsAsNumber,
+            data.getDate()
+          );
+        } else {
+          this.analytics?.logger.warn(
+            `Birthday found "${event.traits?.birthday}" could not be parsed as a Date. Try converting to ISO format.`
+          );
+        }
+      }
+
+      if (event.traits?.email !== undefined) {
+        ReactAppboy.setEmail(event.traits.email);
+      }
+
+      if (event.traits?.firstName !== undefined) {
+        ReactAppboy.setFirstName(event.traits.firstName);
+      }
+
+      if (event.traits?.lastName !== undefined) {
+        ReactAppboy.setLastName(event.traits.lastName);
+      }
+
+      if (event.traits?.gender !== undefined) {
+        const validGenders = ['m', 'f', 'n', 'o', 'p', 'u'];
+        const isValidGender = validGenders.indexOf(event.traits.gender) > -1;
+        if (isValidGender) {
+          ReactAppboy.setGender(
+            event.traits.gender as GenderTypes[keyof GenderTypes]
+          );
+        }
+      }
+
+      if (event.traits?.phone !== undefined) {
+        ReactAppboy.setPhoneNumber(event.traits.phone);
+      }
+
+      if (event.traits?.address !== undefined) {
+        if (event.traits.address.city !== undefined) {
+          ReactAppboy.setHomeCity(event.traits.address.city);
+        }
+        if (event.traits?.address.country !== undefined) {
+          ReactAppboy.setCountry(event.traits.address.country);
+        }
+      }
+
+      const appBoyTraits = [
+        'birthday',
+        'email',
+        'firstName',
+        'lastName',
+        'gender',
+        'phone',
+        'address',
+      ];
+
+      Object.entries(event.traits ?? {}).forEach(([key, value]) => {
+        if (appBoyTraits.indexOf(key) < 0) {
+          ReactAppboy.setCustomUserAttribute(key, value as any);
+        }
+      });
+
       this.lastSeenTraits = {
         anonymousId: event.anonymousId ?? '',
         userId: event.userId,

packages/plugins/plugin-braze/src/methods/__tests__/identify.test.ts

@@ -1,4 +1,3 @@
-import identify from '../identify';
 import {
   changeUser,
   setFirstName,
@@ -12,13 +11,15 @@ import {
   setCustomUserAttribute,
 } from '../__mocks__/react-native-appboy-sdk';
 import type { IdentifyEventType } from '@segment/analytics-react-native';
+import { BrazePlugin } from '../../BrazePlugin';
 
 describe('#identify', () => {
   beforeEach(() => {
     jest.clearAllMocks();
   });
 
   it('calls correct methods #1', () => {
+    const plugin = new BrazePlugin();
     const payload = {
       type: 'identify',
       traits: {
@@ -29,7 +30,7 @@ describe('#identify', () => {
       userId: 'user',
     };
 
-    identify(payload as IdentifyEventType);
+    plugin.identify(payload as IdentifyEventType);
 
     expect(changeUser).toHaveBeenCalledWith('user');
     expect(setFirstName).toHaveBeenCalledWith('John');
@@ -38,6 +39,7 @@ describe('#identify', () => {
   });
 
   it('calls correct methods #2', () => {
+    const plugin = new BrazePlugin();
     const payload = {
       type: 'identify',
       traits: {
@@ -49,14 +51,35 @@ describe('#identify', () => {
       },
     };
 
-    identify(payload as IdentifyEventType);
+    plugin.identify(payload as IdentifyEventType);
 
     expect(setDateOfBirth).toHaveBeenCalledWith(2020, 2, 29);
     expect(setLastName).toHaveBeenCalledWith('Smith');
     expect(setHomeCity).toHaveBeenCalledWith('Denver');
   });
 
+  it('handles invalid dates gracefully', () => {
+    const plugin = new BrazePlugin();
+    const payload = {
+      type: 'identify',
+      traits: {
+        lastName: 'Smith',
+        birthday: 'not a valid date',
+        address: {
+          city: 'Denver',
+        },
+      },
+    };
+
+    plugin.identify(payload as IdentifyEventType);
+
+    expect(setDateOfBirth).not.toHaveBeenCalled();
+    expect(setLastName).toHaveBeenCalledWith('Smith');
+    expect(setHomeCity).toHaveBeenCalledWith('Denver');
+  });
+
   it('calls correct methods #3', () => {
+    const plugin = new BrazePlugin();
     const payload = {
       type: 'identify',
       traits: {
@@ -68,22 +91,23 @@ describe('#identify', () => {
       },
     };
 
-    identify(payload as IdentifyEventType);
+    plugin.identify(payload as IdentifyEventType);
 
     expect(setEmail).toHaveBeenCalledWith('[email protected]');
     expect(setGender).toHaveBeenCalledWith('o');
     expect(setCountry).toHaveBeenCalledWith('US');
   });
 
   it('only calls setGender with defined values', () => {
+    const plugin = new BrazePlugin();
     const payload = {
       type: 'identify',
       traits: {
         gender: 'male',
       },
     };
 
-    identify(payload as IdentifyEventType);
+    plugin.identify(payload as IdentifyEventType);
 
     expect(setGender).not.toHaveBeenCalled();
   });