Feat: Add AdvertisingId Plugin (#574)

* chore: lint

* feat: add advertisingId plugin

* chore: refactor and add shutdown method

* chore: debug with oscar

* feat: add advertisingId plugin

* refactor: rever device_setup.sh

* refactor: clean example app update readme

* chore: remove android deps/packages in example

* chore: remove ad_id permission in manifest

* refactor: remove google play services

* refactor: bump ci sdk to 31

* refactor: revert ci changes

* chore: refactor with Oscar's suggestions

* chore:fix yarn conflict

* chore: fix yarn.lock

* chore: update device_setup.sh to 31

* remove google deps

* chore:revert ci

* chore: refactor ci

* refactor: fix tests remove google-services.json from core

* Update .github/workflows/ci.yml

Co-authored-by: Oscar Bazaldua <[email protected]>

Co-authored-by: Alan Charles <[email protected]>
Co-authored-by: Oscar Bazaldua <[email protected]>

Author: alanjcharles

example/CONTRIBUTING.md

@@ -0,0 +1,37 @@
+# Contributing
+
+We want this community to be friendly and respectful to each other. Please follow it in all your interactions with the project.
+
+## Adding Android Packages
+
+Add necessary Gradle Dependencies
+
+```sh
+    implementation project(':segmentanalyticsreactnative')
+    implementation "com.google.android.gms:play-services-ads-identifier:18.0.1"
+    implementation project(':analyticsreactnativepluginadvertisingid')
+```
+
+
+Add project to `settings.gradle` 
+
+```sh
+include ':analyticsreactnativepluginadvertisingid'
+project(':analyticsreactnativepluginadvertisingid').projectDir = new File(rootProject.projectDir, '../../packages/plugins/plugin-advertising-id/android')
+```
+
+Add package to `MainActivity.java`
+
+```sh
+    @Override
+    protected List<ReactPackage> getPackages() {
+      @SuppressWarnings("UnnecessaryLocalVariable")
+      List<ReactPackage> packages = new PackageList(this).getPackages();
+      // Packages that cannot be autolinked yet can be added manually here, for
+      // AnalyticsReactNativeExample:
+      // packages.add(new MyReactNativePackage());
+      packages.add(new AnalyticsReactNativePackage());
+      packages.add(new AnalyticsReactNativePluginAdvertisingIdPackage());
+      return packages;
+    }
+```

example/android/.project

@@ -16,7 +16,7 @@
 	</natures>
 	<filteredResources>
 		<filter>
-			<id>1644522731203</id>
+			<id>0</id>
 			<name></name>
 			<type>30</type>
 			<matcher>

example/android/.settings/org.eclipse.buildship.core.prefs

@@ -5,7 +5,7 @@ connection.gradle.distribution=GRADLE_DISTRIBUTION(WRAPPER)
 connection.project.dir=
 eclipse.preferences.version=1
 gradle.user.home=
-java.home=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
+java.home=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home
 jvm.arguments=
 offline.mode=false
 override.workspace.settings=true

example/android/app/build.gradle

@@ -1,5 +1,5 @@
 apply plugin: "com.android.application"
-apply plugin: 'com.google.gms.google-services'
+// apply plugin: 'com.google.gms.google-services'
 
 import com.android.build.OutputFile
 
@@ -210,6 +210,8 @@ dependencies {
     }
 
     implementation project(':segmentanalyticsreactnative')
+    // implementation "com.google.android.gms:play-services-ads-identifier:18.0.1"
+    implementation project(':analyticsreactnativepluginadvertisingid')
 
     androidTestImplementation('com.wix:detox:+')
 }

example/android/app/google-services.json

@@ -3,7 +3,7 @@
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
-
+    <!-- <uses-permission android:name="com.google.android.gms.permission.AD_ID"/>  -->
     <application
       android:name=".MainApplication"
       android:label="@string/app_name"
@@ -12,6 +12,10 @@
       android:allowBackup="false"
       android:theme="@style/AppTheme"
       android:networkSecurityConfig="@xml/network_security_config">
+      <!-- Sample AdMob app ID: ca-app-pub-3940256099942544~3347511713 -->
+      <!-- <meta-data
+          android:name="com.google.android.gms.ads.APPLICATION_ID"
+          android:value="ca-app-pub-3940256099942544~3347511713"/> -->
       <activity
         android:name=".MainActivity"
         android:label="@string/app_name"
@@ -39,7 +43,8 @@
       <activity
         android:name="com.zoontek.rnbootsplash.RNBootSplashActivity"
         android:theme="@style/BootTheme"
-        android:launchMode="singleTask">
+        android:launchMode="singleTask"
+        android:exported="true">
         <intent-filter>
           <action android:name="android.intent.action.MAIN" />
           <category android:name="android.intent.category.LAUNCHER" />

example/android/app/src/main/AndroidManifest.xml

@@ -11,6 +11,8 @@
 import java.lang.reflect.InvocationTargetException;
 import java.util.List;
 import com.segmentanalyticsreactnative.AnalyticsReactNativePackage;
+import com.analyticsreactnativepluginadvertisingid.AnalyticsReactNativePluginAdvertisingIdPackage;
+
 
 public class MainApplication extends Application implements ReactApplication {
 
@@ -26,8 +28,8 @@ protected List<ReactPackage> getPackages() {
       List<ReactPackage> packages = new PackageList(this).getPackages();
       // Packages that cannot be autolinked yet can be added manually here, for
       // AnalyticsReactNativeExample:
-      // packages.add(new MyReactNativePackage());
       packages.add(new AnalyticsReactNativePackage());
+      packages.add(new AnalyticsReactNativePluginAdvertisingIdPackage());
       return packages;
     }
 

example/android/app/src/main/java/com/example/segmentanalyticsreactnative/MainApplication.java

@@ -5,9 +5,9 @@ buildscript {
     ext {
         buildToolsVersion = "30.0.2"
         minSdkVersion = 21
-        compileSdkVersion = 30
-        targetSdkVersion = 30
-        ndkVersion = "21.4.7075529"
+        compileSdkVersion = 31
+        targetSdkVersion = 31
+        ndkVersion = "23.2.8568313"
     }
     repositories {
         google()

example/android/build.gradle

@@ -4,3 +4,6 @@ include ':app'
 
 include ':segmentanalyticsreactnative'
 project(':segmentanalyticsreactnative').projectDir = new File(rootProject.projectDir, '../../packages/core/android')
+
+include ':analyticsreactnativepluginadvertisingid'
+project(':analyticsreactnativepluginadvertisingid').projectDir = new File(rootProject.projectDir, '../../packages/plugins/plugin-advertising-id/android')

example/android/settings.gradle

@@ -466,4 +466,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 0c7eb82d495ca56953c50916b7b49e7512632eb6
 
-COCOAPODS: 1.11.3
+COCOAPODS: 1.11.2

example/ios/Podfile.lock

@@ -33,6 +33,9 @@ import { Logger } from './plugins/Logger';
 // @ts-ignore
 import { AmplitudeSessionPlugin } from '@segment/analytics-react-native-plugin-amplitude-session';
 
+//@ts-ignore
+// import { AdvertisingIdPlugin } from '@segment/analytics-react-native-plugin-advertising-id';
+
 const segmentClient = createClient({
   writeKey: 'WRITE_KEY',
   trackAppLifecycleEvents: true,
@@ -59,6 +62,10 @@ segmentClient.add({ plugin: LoggerPlugin });
 
 segmentClient.add({ plugin: new AmplitudeSessionPlugin() });
 
+// segmentClient.add({
+//   plugin: new AdvertisingIdPlugin(),
+// });
+
 const MainStack = createStackNavigator();
 const RootStack = createStackNavigator();
 

example/src/App.tsx

@@ -1,11 +1,11 @@
 arguments=
 auto.sync=false
 build.scans.enabled=false
-connection.gradle.distribution=GRADLE_DISTRIBUTION(VERSION(7.1.1))
-connection.project.dir=../../../example/android
+connection.gradle.distribution=GRADLE_DISTRIBUTION(VERSION(7.4.2))
+connection.project.dir=
 eclipse.preferences.version=1
 gradle.user.home=
-java.home=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
+java.home=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home
 jvm.arguments=
 offline.mode=false
 override.workspace.settings=true

packages/core/android/.settings/org.eclipse.buildship.core.prefs

@@ -17,6 +17,7 @@ buildscript {
 apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
 
+
 def getExtOrDefault(name) {
   return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties['AnalyticsReactNative_' + name]
 }