allow native and RN to share singleton instance (#120)

littlehome-eugene · Eugene Kim · web-flow · commit cd9da63f1826 · 2020-03-19T14:08:16.000-07:00
Co-authored-by: Eugene Kim &lt;eugenekim@Eugenes-MacBook-Pro.local&gt;
diff --git a/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt b/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt
@@ -171,6 +171,11 @@ class RNAnalyticsModule(context: ReactApplicationContext): ReactContextBaseJavaM
             Analytics.setSingletonInstance(
                 RNAnalytics.buildWithIntegrations(builder)
             )
+        } catch(e2: IllegalStateException) {
+            // pass if the error is due to calling setSingletonInstance multiple times
+
+            // if you created singleton in native code already,
+            // you need to promise.resolve for RN to properly operate
         } catch(e: Exception) {
             return promise.reject("E_SEGMENT_ERROR", e)
         }

Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,11 @@ class RNAnalyticsModule(context: ReactApplicationContext): ReactContextBaseJavaM`
`171`	`171`	`Analytics.setSingletonInstance(`
`172`	`172`	`RNAnalytics.buildWithIntegrations(builder)`
`173`	`173`	`)`
	`174`	`+ } catch(e2: IllegalStateException) {`
	`175`	`+ // pass if the error is due to calling setSingletonInstance multiple times`
	`176`	`+`
	`177`	`+ // if you created singleton in native code already,`
	`178`	`+ // you need to promise.resolve for RN to properly operate`
`174`	`179`	`} catch(e: Exception) {`
`175`	`180`	`return promise.reject("E_SEGMENT_ERROR", e)`
`176`	`181`	`}`