please, fix build.graddle! #22
Conversation
please, fix build.graddle y can't use the google analytics integration in android, the project name is wrong
|
@fathyb can you please review the change and merge it, it's breaking my code for long time now. |
|
We'll take a look soon! |
There was a problem hiding this comment.
Hey @juliandondero, we are already testing that Gradle project identifiers are correct in Android E2E tests, this includes all integrations. I’ve pushed your branch to our remote so that it triggers CI checks; the Android tests are failing: https://circleci.com/gh/segmentio/analytics-react-native/937.
You can manually check that these tests are working locally by running yarn && yarn build && yarn test-app test:android.
I suspect that the Gradle version changes how project identifiers are generated. What Gradle version are you using? E2E tests are using 4.4.
If that's the culprit, we could add some logic to build.gradle to require the right project dynamically based on the version.
|
@fathyb hey I'm using same Gradle version 4.4 it's still breaking for me, though changing the path i.e, replacing |
|
Made this change in PR #147, seems to be working/building fine. |
please, fix build.graddle y can't use the google analytics integration in android, the project name is wrong