Skip to content

Swap config comments to match their respective config option. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

Swap config comments to match their respective config option. #26

merged 1 commit into from
Dec 4, 2018

Conversation

caroaguilar
Copy link
Contributor

@caroaguilar caroaguilar commented Dec 4, 2018 •
edited
Loading

The comments for the recordScreenViews and trackAppLifecycleEvents were swapped. I just re-ordered the comments so they can match the correct property.

@f2prateek
Copy link
Contributor

cc @fathyb

fathyb
fathyb approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@fathyb fathyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@fathyb fathyb merged commit 727de66 into segmentio:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f2prateek f2prateek f2prateek approved these changes

@fathyb fathyb fathyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caroaguilar @f2prateek @fathyb