Skip to content

docs: update screen tracking for React Navigation #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

satya164
Copy link
Contributor

Currently, the documentation for screen tracking in React Navigation requires manually implementing a utility to determine the focused screen and can also result in Unknown screen. This updates the documentation to follow the official React Navigation docs to use the built-in methods instead.

The example app also needs to be updated, but currently, I don't have time to do this.

Note: I didn't use useNavigationRef to stay compatible with React Navigation 5.

Docs: https://reactnavigation.org/docs/screen-tracking

Currently, the documentation for screen tracking in React Navigation requires manually implementing a utility to determine the focused screen and can also result in `Unknown` screen. This updates the documentation to follow the official React Navigation docs to use the built-in methods instead.

The example app also needs to be updated, but currently, I don't have time to do this.

Note: I didn't use `useNavigationRef` to stay compatible with React Navigation 5.

Docs: https://reactnavigation.org/docs/screen-tracking
@alanjcharles
Copy link
Contributor

thanks @satya164! will make a note to update the example as soon as we can.

@alanjcharles alanjcharles merged commit 30ba63d into segmentio:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants