Skip to content

fix: map correct facebook events #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Lorex7
Copy link
Contributor

@Lorex7 Lorex7 commented Jun 24, 2022

This PR:

  • map the missing Checkout Started spec’d events to the matching Facebook Event following the docs.
  • correctly trigger a facebook purchase event just in case the event is a fb_mobile_purchase. Previously the event was triggered also for events having the props _valueToSum, e.g. Product Added

Copy link
Contributor

@oscb oscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the PR!

@oscb oscb force-pushed the facebook_event_plugin_fix branch from 005c35e to 0ecb84b Compare June 24, 2022 18:46
@oscb oscb changed the title fix: Map correct Facebook Events fix: map correct facebook events Jun 24, 2022
@oscb oscb merged commit e700ca8 into segmentio:master Jun 24, 2022
oscb pushed a commit that referenced this pull request Jun 24, 2022
@oscb
Copy link
Contributor

oscb commented Jun 24, 2022

🎉 This PR is included in version @segment/analytics-react-native-plugin-facebook-app-events-v0.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oscb oscb added the released label Jun 24, 2022
@Lorex7 Lorex7 deleted the facebook_event_plugin_fix branch June 27, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants