Skip to content

fix: replace native modules with react-native-uuid #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

alanjcharles
Copy link
Contributor

No description provided.

Copy link
Contributor

@oscb oscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Props for the fast turnaround on this.
I left a comment about a test we can remove imo, but otherwise this looks perfect

@alanjcharles alanjcharles merged commit db38836 into master Nov 22, 2022
@alanjcharles alanjcharles deleted the uuid-fix branch November 22, 2022 21:46
@alanjcharles
Copy link
Contributor Author

alanjcharles commented Nov 22, 2022

#705

@SchneiderOr
Copy link

Hey why this isn't reflected in master 2.9.1? i still getting this error on dev

oscb pushed a commit that referenced this pull request Nov 30, 2022
## [@segment/analytics-react-native-v2.10.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.9.1...@segment/analytics-react-native-v2.10.0) (2022-11-30)

### Features

* add Flush Policies ([#703](#703)) ([004b596](004b596))
* added errorHandler option to client ([#713](#713)) ([b95788b](b95788b))

### Bug Fixes

* add segmentDestination plugin to exports ([#712](#712)) ([d47ceb1](d47ceb1))
* Firebase custom screen properties ([#707](#707)) ([18b75af](18b75af))
* replace native modules with react-native-uuid ([#718](#718)) ([db38836](db38836))
@oscb
Copy link
Contributor

oscb commented Nov 30, 2022

🎉 This PR is included in version @segment/analytics-react-native-v2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oscb oscb added the released label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants