fix: prevent locking before setting new user data #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjcharles
approved these changes
Jan 31, 2023
oscb
pushed a commit
that referenced
this pull request
Feb 2, 2023
## [@segment/analytics-react-native-v2.11.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.10.1...@segment/analytics-react-native-v2.11.0) (2023-02-02) ### Features * add end method to flush policies for cleanup ([#753](#753)) ([96b0893](96b0893)) ### Bug Fixes * prevent locking before setting new user data ([#751](#751)) ([d8439e3](d8439e3)) * refactor allSettled to remove dependencies ([#746](#746)) ([479e468](479e468)) * remove non-required parameters from native calls ([#750](#750)) ([6ebd65e](6ebd65e))
|
🎉 This PR is included in version @segment/analytics-react-native-v2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
identifyfollowed by atrackcall without awaiting would still end up withuserIdnot being set correctly.The order is important inside
InjectUserInfo, previously it was locking when accessing the current user data before getting to set, which causedtrackto finish beforeidentify.It isn't required to do a
getbeforesetas the setter will get access to its most current state when run.Added tests to prevent regressions.