Skip to content

Fix Intercom connection modes #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2022
Merged

Fix Intercom connection modes #2923

merged 2 commits into from
May 19, 2022

Conversation

markzegarelli
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

Closes #2922

@markzegarelli markzegarelli requested review from stayseesong and a team as code owners May 18, 2022 23:20
@markzegarelli markzegarelli added the content-update updates to content that are not new features, includes grammar fixes, added notes label May 18, 2022
@markzegarelli markzegarelli merged commit 57bba7e into develop May 19, 2022
@markzegarelli markzegarelli deleted the 2922-intercom branch May 19, 2022 16:11
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

markzegarelli pushed a commit that referenced this pull request May 19, 2022
* Update index.md (#2920)

add missing "title" header

* Session Id and Session Number using gtag

* Update index.md

* Update index.md

* Update index.md

* Fix Intercom connection modes (#2923)

* Fix Intercom connection modes

* Update src/connections/destinations/catalog/intercom/index.md

Co-authored-by: stayseesong <[email protected]>

Co-authored-by: stayseesong <[email protected]>

* Bump nokogiri from 1.13.4 to 1.13.6 (#2924)

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.4 to 1.13.6.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.13.4...v1.13.6)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update documentation about testing (#2917)

* Update documentation about testing

* Update src/connections/sources/catalog/libraries/server/python/index.md

Co-authored-by: markzegarelli <[email protected]>

Co-authored-by: markzegarelli <[email protected]>

* Apply suggestions from code review

* fixes

Co-authored-by: Segment Docs Robot <[email protected]>
Co-authored-by: Thomas Gilbert <[email protected]>
Co-authored-by: Gavin-Fitzpatrick <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: g-normand <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Content]:
2 participants