Skip to content

Destination function batching updates [DOC-527] #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 30, 2022
Merged

Conversation

forstisabella
Copy link
Contributor

Proposed changes

  • Made updates requested in this Jira ticket
  • Removed unnecessary screenshots & improved existing alt text
  • Made Vale updates

Merge timing

On June 30, 2022

Related issues (optional)

DOC-527

@forstisabella forstisabella added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jun 24, 2022
@forstisabella forstisabella requested a review from a team as a code owner June 24, 2022 16:18
@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 05b22c7
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/62bafa1f99b214000943194a
😎 Deploy Preview https://deploy-preview-3115--segment-docs.netlify.app/connections/functions/destination-functions
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious about the decision to comment images vs remove them from the doc.


When you click **Build**, a code editor appears. Use the editor to write the code for your function, configure settings, and test the function's behavior.

![Functions Editor](images/editor-dest.png)
<!--- ![A screenshot of the Functions Editor in the Segment app, showing one of the Segment sample functions and the test panel in the code editor](images/editor-dest.png) --->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forstisabella Is there a reason to comment this out vs remove the image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markzegarelli That's my mistake: I commented out the images to test if they were integral to the docs (this one wasn't.) I'll go back through and make sure they're all removed!

@forstisabella forstisabella merged commit 0b40736 into develop Jun 30, 2022
@forstisabella forstisabella deleted the DOC-527-IG branch June 30, 2022 12:40
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants