Skip to content

Analytics Node Next #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 19, 2023
Merged

Analytics Node Next #3967

merged 15 commits into from
Jan 19, 2023

Conversation

stayseesong
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@stayseesong stayseesong requested a review from a team as a code owner December 16, 2022 23:47
@stayseesong stayseesong requested review from rchinn1 and removed request for a team December 16, 2022 23:47
@stayseesong stayseesong marked this pull request as draft December 16, 2022 23:47
@stayseesong stayseesong removed the request for review from rchinn1 December 16, 2022 23:47
@stayseesong stayseesong requested a review from silesky January 4, 2023 18:02
@stayseesong
Copy link
Contributor Author

hi @silesky, here's a draft of the docs for the Analytics Node Next changes that we discussed before the holidays. Could you please take a look and input any comments or note other changes that need to be made? Thank you!

redirect_from: '/connections/sources/catalog/libraries/server/node-js/quickstart/'
strat: node-js
---

> warning "Deprecation of Analytics Node.js Classic"
> On [date], Segment will end support for Analytics Node.js Classic, which includes versions [1.x.x] and older. Upgrade to Analytics Node.js 2.0. See the [Analytics Node.js 2.0] docs to learn more.
Copy link
Contributor

@silesky silesky Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lean towards saying that the "deprecation" date is 4/1/2023 (the end of Q1). cc @chrisradek @tlalfano

I created a story https://segment.atlassian.net/browse/LIBWEB-1309

---

Our Node.js library lets you record analytics data from your node code. The requests hit our servers, and then we route your data to any destinations you have enabled.
> warning "Deprecation of Analytics Node.js Classic"
> On [date], Segment will end support for Analytics Node.js Classic, which includes versions [1.x.x] and older. Upgrade to the new version of Analytics Node.js. See the updated [Analytics Node.js] docs to learn more.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silesky what's the current version number of the classic version?

Copy link
Contributor

@silesky silesky Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.2.0

seen: https://www.npmjs.com/package/analytics-node?activeTab=versions

This detail about versions is not really needed IMO, as we are deprecating one entire package in favor of a new package, so we are starting over on a new package who's first non beta version will be 1.0 (currently at 0.1-beta.9).

Old package: analytics-node (to be deprecated)
New package: @segment/analytics-node

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 0d069f0
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/63c1dfd895bd170009b5a5cb
😎 Deploy Preview https://deploy-preview-3967--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stayseesong stayseesong marked this pull request as ready for review January 17, 2023 17:37
Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I found a few instances of absolute links to docs pages, like here for example.



## Plugin architecture
When you develop against [Analytics.js 2.0](/docs/connections/sources/catalog/libraries/website/javascript/), the plugins you write can augment functionality, enrich data, and control the flow and delivery of events. From modifying event payloads to changing analytics functionality, plugins help to speed up the process of getting things done.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question...but I assume this just means that Node plugins are bound by the same constraints as A.js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silesky can you confirm? ^ I'm not sure if they're bound by the same constraints

Copy link
Contributor

@silesky silesky Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph LGTM.

Yes, they share the same plugin pipeline code so they should have feature parity.

I might be able to answer this question better if you gave me an example of what you mean by constraints, but I'm pretty ok with the text as is FWIW

@stayseesong stayseesong merged commit a742562 into develop Jan 19, 2023
@stayseesong stayseesong deleted the DOC-631 branch January 19, 2023 17:53
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@stayseesong stayseesong added the new-integration Added a new source or destination label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants