Skip to content

Update Amplitude Classic Destination [DOC-629] #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

Update Amplitude Classic Destination [DOC-629] #4048

merged 2 commits into from
Jan 13, 2023

Conversation

pwseg
Copy link
Contributor

@pwseg pwseg commented Jan 13, 2023

Proposed changes

  • Added note about device-mode regional endpoint support.
  • Fixed some broken links.
  • Removed directional language.
  • Fixed some weird stuff.

Merge timing

  • ASAP once approved.

@pwseg pwseg added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jan 13, 2023
@pwseg pwseg marked this pull request as ready for review January 13, 2023 16:16
@pwseg pwseg requested review from stayseesong, markzegarelli and a team as code owners January 13, 2023 16:16
@pwseg pwseg merged commit 59a7065 into develop Jan 13, 2023
@pwseg pwseg deleted the DOC-629-amplitude-classic-device-mode branch January 13, 2023 18:32
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markzegarelli markzegarelli markzegarelli approved these changes

@stayseesong stayseesong Awaiting requested review from stayseesong

Assignees
No one assigned
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwseg @markzegarelli