Skip to content

ad blocking in A.js 2.0 #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2023
Merged

ad blocking in A.js 2.0 #4541

merged 2 commits into from
Apr 6, 2023

Conversation

stayseesong
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@stayseesong stayseesong requested a review from a team as a code owner April 5, 2023 23:06
@stayseesong stayseesong requested review from forstisabella and removed request for a team April 5, 2023 23:06
@@ -845,6 +845,21 @@ For more information, visit the [Segment localstorage-retry library](https://git

You can set the `debug` cookie to `analytics.js` to log debug messages from Analytics.js to the console.

## Ad Blocking
Segment doesn't endorse bypassing ad blockers for client-side tracking. You have control as to what gets loaded on the page, because you can add a plugin to block third party scripts from loading, which includes Segment. As you can expect some data loss in client-side tracking, there are three routes Segment recommends you to choose from:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Segment doesn't endorse bypassing ad blockers for client-side tracking. You have control as to what gets loaded on the page, because you can add a plugin to block third party scripts from loading, which includes Segment. As you can expect some data loss in client-side tracking, there are three routes Segment recommends you to choose from:
Segment doesn't endorse bypassing ad blockers for client-side tracking. You have control as to what gets loaded on the page, but your users can add a plugin to block third party scripts from loading, which includes Segment. As you can expect some data loss in client-side tracking, there are three routes Segment recommends you to choose from:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also put it this way!

@stayseesong stayseesong merged commit 1602db0 into develop Apr 6, 2023
@stayseesong stayseesong deleted the LIBWEB-1338 branch April 6, 2023 16:43
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants