Adding info about new http client #4989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchinn1
requested changes
Jul 14, 2023
There was a problem hiding this comment.
@MichaelGHSeg looks good. Just a few updates to align this with our style guide.
rchinn1
added
the
content-update
Co-authored-by: rchinn-segment <[email protected]>
Co-authored-by: rchinn-segment <[email protected]>
silesky
reviewed
Jul 14, 2023
silesky
reviewed
Jul 14, 2023
silesky
reviewed
Jul 14, 2023
rchinn1
approved these changes
Jul 14, 2023
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We're working on adding a new interface to customize the http client used in analytics-next node.
Merge timing
Once segmentio/analytics-next#880 is mergedImmediately
Related issues (optional)
LIBWEB-1395