Skip to content

Re-list Intercom for mobile destination plugins #6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Conversation

niallzato
Copy link
Contributor

@niallzato niallzato commented Feb 27, 2024

Proposed changes

The Kotlin and Swift Intercom destination plugins depend on the Intercom destination catalog listing. This destination is currently delisted in our catalog (private-beta) as we want folks to use the newer Actions based destinations instead. However, this makes it impossible to add the Intercom destination plugins for mobile, as folks cannot find the Intercom catalog listing.

To fix this, I will change the catalog status of Intercom to public, and also remove most of the content from the Intercom doc. We don't want new customers adding this destination for browser or server, so I want to be extremely clear this is only for the Swift and the Kotlin Plugins.

Once this is deployed, I'll toggle the status of Intercom

@niallzato niallzato requested a review from a team as a code owner February 27, 2024 12:07
@niallzato niallzato requested review from forstisabella and alanjcharles and removed request for a team February 27, 2024 12:07
@niallzato niallzato added the KCS label Feb 28, 2024
Copy link
Contributor

@alanjcharles alanjcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@niallzato niallzato merged commit 1b44ad1 into develop Feb 29, 2024
@niallzato niallzato deleted the niall/add_intercom branch February 29, 2024 16:06
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants