-
Notifications
You must be signed in to change notification settings - Fork 367
Wisepops - Documentation for the new goal tracking #6401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…gin-documentation-for-new-goal-tracking WIS-3633 Update Wisepops documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small changes and we'll be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boris-hocde - I think we can replace "appropriate field" and the screenshot with just the "Goal Name" field!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forstisabella Thanks for spotting this. This field name is actually changed to "Goal Identifier". I'm updating the text and screenshot. I think that the screenshot is still valuable, as it shows that the "
shouldn't be included. And that it can be pasted as is, without using a Segment event variable. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boris-hocde - I would still recommend replacing the screenshot with written text. None of the technical writers on the team have access to Wisepops, so if the UI or format of the identifier were to change, we'd have no way of updating this content.
Would the comment that I proposed adequately cover that you can copy the identifier, without the double quotes, into Segment?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me. I took this occasion to update the existing screenshots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forstisabella Ready for new review 🙇
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: forstisabella <[email protected]>
…s-wis-3633-update-segment-plugin-documentation-for-new-goal-tracking
…-wis-3633-update-segment-plugin-documentation-for-new-goal-tracking # Conflicts: # src/connections/destinations/catalog/actions-wisepops/index.md
…gin-documentation-for-new-goal-tracking WIS-3633 Update field name Goal Identifier
This looks beautiful - thank you so much for all the work you did on this!!! |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Wisepops is introducing a new way of tracking goals. See the action-destination PR. We're updating the doc to reflect these changes.
Merge timing
Depending on a specific project: If possible, when the action-destination PR is merged