Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

fix type export bug in index file #45

Closed

Conversation

danychi
Copy link

@danychi danychi commented Jan 27, 2023

I was getting the following issues when running the project as an external dependency
Screenshot 2023-01-27 at 13 27 31

The issue came from not specifying in the export that Store, Notify, Unsubscribe were types, so then when it gets converted to JS, the export of those types were not getting removed.

Before
Screenshot 2023-01-27 at 13 28 39
After
Screenshot 2023-01-27 at 13 34 09

@oscb
Copy link
Contributor

oscb commented Mar 7, 2023

@danychi Hey, sorry for the lack of updates. We were in the middle of transitioning this repository into the monorepo. I will include this fix in there. Thanks!

@oscb
Copy link
Contributor

oscb commented Mar 13, 2023

Merged at: segmentio/analytics-react-native#779

@oscb oscb closed this Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants