Skip to content

Commit 1338b6b

Browse files
authored
Bump GeckoDriver to 0.28.0 (#1137)
* Bump GeckoDriver to 0.28.0 * Using new environment files in GitHub actions
1 parent 4716377 commit 1338b6b

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

.github/workflows/build-test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,18 @@ jobs:
2727
python-version: 3.8
2828
- name: Get branch name (only for push to branch)
2929
if: github.event_name == 'push'
30-
run: echo "::set-env name=BRANCH::$(echo ${PUSH_BRANCH##*/})"
30+
run: echo "BRANCH=$(echo ${PUSH_BRANCH##*/})" >> $GITHUB_ENV
3131
env:
3232
PUSH_BRANCH: ${{ github.ref }}
3333
- name: Get target branch name (only for PRs)
3434
if: github.event_name == 'pull_request'
35-
run: echo "::set-env name=BRANCH::$(echo ${TARGET_BRANCH##*/})"
35+
run: echo "BRANCH=$(echo ${TARGET_BRANCH##*/})" >> $GITHUB_ENV
3636
env:
3737
TARGET_BRANCH: ${{ github.head_ref }}
3838
- name: Output branch name
3939
run: echo ${BRANCH}
4040
- name: Sets build date
41-
run: echo ::set-env name=BUILD_DATE::$(date '+%Y%m%d')
41+
run: echo "BUILD_DATE=$(date '+%Y%m%d')" >> $GITHUB_ENV
4242
- name: Build Docker images
4343
run: VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make build
4444
- name: Test Docker images

.github/workflows/deploy.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,25 +20,25 @@ jobs:
2020
- name: Output Docker info
2121
run: docker info
2222
- name: Sets build date
23-
run: echo ::set-env name=BUILD_DATE::$(date '+%Y%m%d')
23+
run: echo "BUILD_DATE=$(date '+%Y%m%d')" >> $GITHUB_ENV
2424
- name: Sets prerelease to false by default
25-
run: echo ::set-env name=PRERELEASE::false
25+
run: echo "PRERELEASE=false" >> $GITHUB_ENV
2626
- name: Build base image to get Grid version
2727
run: VERSION="local" BUILD_DATE=${BUILD_DATE} make base
2828
- name: Get Grid version
2929
# sed used to remove last comma of Selenium version output
30-
run: echo ::set-env name=GRID_VERSION::$(docker run --rm selenium/base:local-${BUILD_DATE} java -jar /opt/selenium/selenium-server.jar hub --version | awk '{print $3}' | sed 's/\(.*\),/\1 /')
30+
run: echo "BUILD_DATE=$(docker run --rm selenium/base:local-${BUILD_DATE} java -jar /opt/selenium/selenium-server.jar hub --version | awk '{print $3}' | sed 's/\(.*\),/\1 /')" >> $GITHUB_ENV
3131
- name: Is it a prerelease?
32-
run: echo ::set-env name=GRID_VERSION::${GRID_VERSION}-prerelease && echo ::set-env name=PRERELEASE::true
32+
run: echo "GRID_VERSION=${GRID_VERSION}-prerelease" >> $GITHUB_ENV && echo "PRERELEASE=true" >> $GITHUB_ENV
3333
if: contains(toJson(github.event.commits), '[prerelease]') == true
3434
- name: Display Grid version
3535
run: echo ${GRID_VERSION}
3636
- name: Remove local Docker tag
3737
run: docker rmi selenium/base:local-${BUILD_DATE}
3838
- name: Sets env var for the next tag
39-
run: echo ::set-env name=NEXT_TAG::"${GRID_VERSION}"-${BUILD_DATE}
39+
run: echo "NEXT_TAG=${GRID_VERSION}-${BUILD_DATE}" >> $GITHUB_ENV
4040
- name: Get latest tag
41-
run: echo ::set-env name=LATEST_TAG::$(git tag | tail -1)
41+
run: echo "LATEST_TAG=$(git tag | tail -1)" >> $GITHUB_ENV
4242
- name: Display latest tag
4343
run: echo ${LATEST_TAG}
4444
- name: Update tag in docs and files

.github/workflows/test-video.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,18 @@ jobs:
2727
python-version: 3.8
2828
- name: Get branch name (only for push to branch)
2929
if: github.event_name == 'push'
30-
run: echo "::set-env name=BRANCH::$(echo ${PUSH_BRANCH##*/})"
30+
run: echo "BRANCH=$(echo ${PUSH_BRANCH##*/})" >> $GITHUB_ENV
3131
env:
3232
PUSH_BRANCH: ${{ github.ref }}
3333
- name: Get target branch name (only for PRs)
3434
if: github.event_name == 'pull_request'
35-
run: echo "::set-env name=BRANCH::$(echo ${TARGET_BRANCH##*/})"
35+
run: echo "BRANCH=$(echo ${TARGET_BRANCH##*/})" >> $GITHUB_ENV
3636
env:
3737
TARGET_BRANCH: ${{ github.head_ref }}
3838
- name: Output branch name
3939
run: echo ${BRANCH}
4040
- name: Sets build date
41-
run: echo ::set-env name=BUILD_DATE::$(date '+%Y%m%d')
41+
run: echo "BUILD_DATE=$(date '+%Y%m%d')" >> $GITHUB_ENV
4242
- name: Run Docker Compose to record video
4343
run: USE_RANDOM_USER_ID=${USE_RANDOM_USER} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make test_video
4444
env:

NodeFirefox/Dockerfile.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ RUN FIREFOX_DOWNLOAD_URL=$(if [ $FIREFOX_VERSION = "latest" ] || [ $FIREFOX_VERS
2020
# GeckoDriver
2121
#============
2222
ARG GECKODRIVER_VERSION=latest
23-
RUN GK_VERSION=$(if [ ${GECKODRIVER_VERSION:-latest} = "latest" ]; then echo "0.27.0"; else echo $GECKODRIVER_VERSION; fi) \
23+
RUN GK_VERSION=$(if [ ${GECKODRIVER_VERSION:-latest} = "latest" ]; then echo "0.28.0"; else echo $GECKODRIVER_VERSION; fi) \
2424
&& echo "Using GeckoDriver version: "$GK_VERSION \
2525
&& wget --no-verbose -O /tmp/geckodriver.tar.gz https://github.com/mozilla/geckodriver/releases/download/v$GK_VERSION/geckodriver-v$GK_VERSION-linux64.tar.gz \
2626
&& rm -rf /opt/geckodriver \

0 commit comments

Comments
 (0)