Skip to content

Commit 8755242

Browse files
authored
Upgrading python tests to avoid warnings (#1234)
1 parent 252bc7c commit 8755242

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

tests/SeleniumTests/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ def test_with_frames(self):
2121
driver.get('http://the-internet.herokuapp.com/nested_frames')
2222
driver.switch_to.frame('frame-top')
2323
driver.switch_to.frame('frame-middle')
24-
self.assertTrue(driver.find_element_by_id('content').text == "MIDDLE", "content should be MIDDLE")
24+
self.assertTrue(driver.find_element(By.ID, 'content').text == "MIDDLE", "content should be MIDDLE")
2525

2626
# https://github.com/tourdedave/elemental-selenium-tips/blob/master/05-select-from-a-dropdown/python/dropdown.py
2727
def test_select_from_a_dropdown(self):
2828
driver = self.driver
2929
driver.get('http://the-internet.herokuapp.com/dropdown')
30-
dropdown_list = driver.find_element_by_id('dropdown')
31-
options = dropdown_list.find_elements_by_tag_name('option')
30+
dropdown_list = driver.find_element(By.ID, 'dropdown')
31+
options = dropdown_list.find_elements(By.TAG_NAME, 'option')
3232
for opt in options:
3333
if opt.text == 'Option 1':
3434
opt.click()
@@ -43,7 +43,7 @@ def test_select_from_a_dropdown(self):
4343
def test_visit_basic_auth_secured_page(self):
4444
driver = self.driver
4545
driver.get('http://admin:[email protected]/basic_auth')
46-
page_message = driver.find_element_by_css_selector('.example p').text
46+
page_message = driver.find_element(By.CSS_SELECTOR, '.example p').text
4747
self.assertTrue(page_message == 'Congratulations! You must have the proper credentials.')
4848

4949
def test_play_video(self):
@@ -55,7 +55,7 @@ def test_play_video(self):
5555
)
5656
video.click()
5757
wait.until(
58-
lambda d: d.find_element_by_tag_name('video').get_property('currentTime')
58+
lambda d: d.find_element(By.TAG_NAME, 'video').get_property('currentTime')
5959
)
6060
paused = video.get_property('paused')
6161
self.assertFalse(paused)

tests/bootstrap.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
cd tests || true
33

44
if [ "${CI:-false}" = "false" ]; then
5-
pip install virtualenv | grep -v 'Requirement already satisfied'
5+
pip3 install virtualenv | grep -v 'Requirement already satisfied'
66
virtualenv docker-selenium-tests
77
source docker-selenium-tests/bin/activate
88
fi
99

10-
python -m pip install selenium==4.0.0a6.post2 \
10+
python -m pip install selenium==4.0.0.a7 \
1111
docker===4.2.0 \
1212
| grep -v 'Requirement already satisfied'
1313

0 commit comments

Comments
 (0)