Adding log output for SE_OPTS (#1243)

Author: diemol

EventBus/start-selenium-grid-eventbus.sh

@@ -15,6 +15,10 @@ if [ ! -z "$SE_EVENT_BUS_PORT" ]; then
   PORT_CONFIG="--port ${SE_EVENT_BUS_PORT}"
 fi
 
+if [ ! -z "$SE_OPTS" ]; then
+  echo "Appending Selenium options: ${SE_OPTS}"
+fi
+
 java ${JAVA_OPTS} -jar /opt/selenium/selenium-server.jar event-bus \
   ${HOST_CONFIG} \
   ${PORT_CONFIG} \

Hub/start-selenium-grid-hub.sh

@@ -21,5 +21,7 @@ fi
 java ${JAVA_OPTS} -jar /opt/selenium/selenium-server.jar hub \
   --session-request-timeout ${SE_SESSION_REQUEST_TIMEOUT} \
   --session-retry-interval ${SE_SESSION_RETRY_INTERVAL} \
-  --relax-checks \
-  ${SE_RELAX_CHECKS} ${HOST_CONFIG} ${PORT_CONFIG} ${SE_OPTS}
+  --relax-checks ${SE_RELAX_CHECKS} \
+  ${HOST_CONFIG} \
+  ${PORT_CONFIG} \
+  ${SE_OPTS}

NodeBase/start-selenium-node.sh

@@ -27,6 +27,10 @@ if [[ -z "${SE_EVENT_BUS_SUBSCRIBE_PORT}" ]]; then
   exit 1
 fi
 
+if [ ! -z "$SE_OPTS" ]; then
+  echo "Appending Selenium options: ${SE_OPTS}"
+fi
+
 /opt/bin/generate_config
 
 echo "Starting Selenium Grid Node with configuration: "

NodeDocker/start-selenium-grid-node-docker.sh

@@ -20,6 +20,10 @@ if [[ -z "${SE_EVENT_BUS_SUBSCRIBE_PORT}" ]]; then
   exit 1
 fi
 
+if [ ! -z "$SE_OPTS" ]; then
+  echo "Appending Selenium options: ${SE_OPTS}"
+fi
+
 java ${JAVA_OPTS} -jar /opt/selenium/selenium-server.jar node \
   --publish-events tcp://"${SE_EVENT_BUS_HOST}":${SE_EVENT_BUS_PUBLISH_PORT} \
   --subscribe-events tcp://"${SE_EVENT_BUS_HOST}":${SE_EVENT_BUS_SUBSCRIBE_PORT} \

README.md

@@ -367,7 +367,7 @@ ___
 You can pass `SE_OPTS` variable with additional commandline parameters for starting a hub or a node.
 
 ``` bash
-$ docker run -d -p 4444:4444 -e SE_OPTS="-debug" --name selenium-hub selenium/hub:4.0.0-beta-2-20210317
+$ docker run -d -p 4444:4444 -e SE_OPTS="--log-level FINE" --name selenium-hub selenium/hub:4.0.0-beta-2-20210317
 ```
 
 ### JAVA_OPTS Java Environment Options

Standalone/Dockerfile.txt

@@ -10,5 +10,10 @@ COPY start-selenium-standalone.sh /opt/bin/start-selenium-standalone.sh
 #==============================
 COPY selenium.conf /etc/supervisor/conf.d/
 
+# Boolean value, maps "--relax-checks"
+ENV SE_RELAX_CHECKS true
+
 
 EXPOSE 4444
+
+

Standalone/start-selenium-standalone.sh

@@ -2,5 +2,10 @@
 #
 # IMPORTANT: Change this file only in directory Standalone!
 
+if [ ! -z "$SE_OPTS" ]; then
+  echo "Appending Selenium options: ${SE_OPTS}"
+fi
+
 java ${JAVA_OPTS} -jar /opt/selenium/selenium-server.jar standalone \
-  --relax-checks true ${SE_OPTS}
+  --relax-checks ${SE_RELAX_CHECKS} \
+  ${SE_OPTS}

StandaloneDocker/Dockerfile.txt

@@ -12,3 +12,5 @@ COPY start-selenium-grid-standalone-docker.sh \
 
 COPY selenium-grid-standalone-docker.conf /etc/supervisor/conf.d/
 
+# Boolean value, maps "--relax-checks"
+ENV SE_RELAX_CHECKS true

StandaloneDocker/start-selenium-grid-standalone-docker.sh

@@ -5,8 +5,12 @@ set -e
 
 echo "Starting Selenium Grid Standalone Docker..."
 
+if [ ! -z "$SE_OPTS" ]; then
+  echo "Appending Selenium options: ${SE_OPTS}"
+fi
+
 java ${JAVA_OPTS} -jar /opt/selenium/selenium-server.jar standalone \
-  --relax-checks true \
+  --relax-checks ${SE_RELAX_CHECKS} \
   --detect-drivers false \
   --config /opt/bin/config.toml \
   ${SE_OPTS}