Skip to content

Commit e0a085c

Browse files
authored
Bump to Edge Beta (#1281)
* Bump to Edge Beta * Mounting shm for testing * Checking edge video * No need to test again this * Disabling tests in Edge again
1 parent f272dbd commit e0a085c

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

.github/workflows/test-video.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ jobs:
1414
if: contains(toJson(github.event.commits), '[skip ci]') == false
1515
name: Test video recorded through Docker Selenium
1616
runs-on: ubuntu-20.04
17-
strategy:
18-
matrix:
19-
use-random-user: [false, true]
2017
steps:
2118
- uses: actions/checkout@v1
2219
- name: Output Docker info
@@ -41,8 +38,6 @@ jobs:
4138
run: echo "BUILD_DATE=$(date '+%Y%m%d')" >> $GITHUB_ENV
4239
- name: Run Docker Compose to record video
4340
run: USE_RANDOM_USER_ID=${USE_RANDOM_USER} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make test_video
44-
env:
45-
USE_RANDOM_USER: ${{ matrix.use-random-user }}
4641
- name: Upload recorded Chrome video
4742
uses: actions/upload-artifact@v2
4843
with:

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -377,10 +377,6 @@ test: test_chrome \
377377
test_firefox_standalone \
378378
test_opera_standalone
379379

380-
# Disabling Edge testing for this release as Dev seems unstable
381-
# test_edge \
382-
# test_edge_standalone \
383-
384380

385381
test_chrome:
386382
VERSION=$(TAG_VERSION) NAMESPACE=$(NAMESPACE) ./tests/bootstrap.sh NodeChrome

NodeEdge/Dockerfile.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ USER root
44
# Microsoft Edge
55
#============================================
66
# can specify versions by EDGE_VERSION;
7-
# e.g. microsoft-edge-dev=88.0.692.0-1
7+
# e.g. microsoft-edge-beta=88.0.692.0-1
88
#============================================
9-
ARG EDGE_VERSION="microsoft-edge-dev"
9+
ARG EDGE_VERSION="microsoft-edge-beta"
1010
RUN wget -q -O - https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \
1111
&& echo "deb https://packages.microsoft.com/repos/edge stable main" >> /etc/apt/sources.list.d/microsoft-edge.list \
1212
&& apt-get update -qqy \

tests/test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ def launch_container(container, **kwargs):
132132
container_id = client.containers.run("%s/%s:%s" % (NAMESPACE, IMAGE_NAME_MAP[container], VERSION),
133133
detach=True,
134134
environment=environment,
135+
shm_size="2G",
135136
**kwargs).short_id
136137
logger.info("%s up and running" % container)
137138
return container_id

0 commit comments

Comments
 (0)