Skip to content

Commit fb28eea

Browse files
brunobritorjdiemol
andauthored
Support to nodes livenessProbe into the Helm Chart (#1897)
In the Helm Chart, there was no ```livenessProbe``` support for option ```chromeNode```, ```firefoxNode```, and ```edgeNode```. This commit adds these three Helm Chart values: - ```chromeNode.livenessProbe: {}``` - ```firefoxNode.livenessProbe {}``` - ```edgeNode.livenessProbe: {}``` The bellow properties will end up in the pod livenessProbe for the respective node pod. Fixes #1895 Co-authored-by: Diego Molina <[email protected]>
1 parent a027f26 commit fb28eea

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

charts/selenium-grid/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ This table contains the configuration parameters of the chart and their default
127127
| `chromeNode.service.annotations` | `{}` | Custom annotations for service |
128128
| `chromeNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
129129
| `chromeNode.startupProbe` | `{}` | Probe to check pod is started successfully |
130+
| `chromeNode.livenessProbe` | `{}` | Liveness probe settings |
130131
| `chromeNode.terminationGracePeriodSeconds` | `30` | Time to graceful terminate container (default: 30s) |
131132
| `chromeNode.lifecycle` | `{}` | hooks to make pod correctly shutdown or started |
132133
| `chromeNode.extraVolumeMounts` | `[]` | Extra mounts of declared ExtraVolumes into pod |
@@ -161,6 +162,7 @@ This table contains the configuration parameters of the chart and their default
161162
| `firefoxNode.service.annotations` | `{}` | Custom annotations for service |
162163
| `firefoxNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
163164
| `firefoxNode.startupProbe` | `{}` | Probe to check pod is started successfully |
165+
| `firefoxNode.livenessProbe` | `{}` | Liveness probe settings |
164166
| `firefoxNode.terminationGracePeriodSeconds` | `30` | Time to graceful terminate container (default: 30s) |
165167
| `firefoxNode.lifecycle` | `{}` | hooks to make pod correctly shutdown or started |
166168
| `firefoxNode.extraVolumeMounts` | `[]` | Extra mounts of declared ExtraVolumes into pod |
@@ -195,6 +197,7 @@ This table contains the configuration parameters of the chart and their default
195197
| `edgeNode.service.annotations` | `{}` | Custom annotations for service |
196198
| `edgeNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
197199
| `edgeNode.startupProbe` | `{}` | Probe to check pod is started successfully |
200+
| `edgeNode.livenessProbe` | `{}` | Liveness probe settings |
198201
| `edgeNode.terminationGracePeriodSeconds` | `30` | Time to graceful terminate container (default: 30s) |
199202
| `edgeNode.lifecycle` | `{}` | hooks to make pod correctly shutdown or started |
200203
| `edgeNode.extraVolumeMounts` | `[]` | Extra mounts of declared ExtraVolumes into pod |

charts/selenium-grid/templates/_helpers.tpl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,9 @@ template:
153153
{{- with .node.startupProbe }}
154154
startupProbe: {{- toYaml . | nindent 10 }}
155155
{{- end }}
156+
{{- with .node.livenessProbe }}
157+
livenessProbe: {{- toYaml . | nindent 10 }}
158+
{{- end }}
156159
{{- if or .Values.global.seleniumGrid.imagePullSecret .node.imagePullSecret }}
157160
imagePullSecrets:
158161
- name: {{ default .Values.global.seleniumGrid.imagePullSecret .node.imagePullSecret }}

charts/selenium-grid/values.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,10 @@ chromeNode:
429429
# port: 5555
430430
# failureThreshold: 120
431431
# periodSeconds: 5
432+
433+
# Liveness probe settings
434+
livenessProbe: {}
435+
432436
# Time to wait for pod termination
433437
terminationGracePeriodSeconds: 30
434438
lifecycle: {}
@@ -541,6 +545,10 @@ firefoxNode:
541545
# port: 5555
542546
# failureThreshold: 120
543547
# periodSeconds: 5
548+
549+
# Liveness probe settings
550+
livenessProbe: {}
551+
544552
# Time to wait for pod termination
545553
terminationGracePeriodSeconds: 30
546554
lifecycle: {}
@@ -650,6 +658,10 @@ edgeNode:
650658
# port: 5555
651659
# failureThreshold: 120
652660
# periodSeconds: 5
661+
662+
# Liveness probe settings
663+
livenessProbe: {}
664+
653665
# Time to wait for pod termination
654666
terminationGracePeriodSeconds: 30
655667
lifecycle: {}

0 commit comments

Comments
 (0)