Fixed a corner case where numpy's np.float32 nans are not ignored when using ignore_nan_equality #376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following case:
As you can see, when there are other differences and we are using np.float32 typed arrays, the
np.nan
values are not ignored, despite settingignore_nan_inequality=True
.Notice that in case of the default
np.float64
type, it doesn't happen:Also, no diffs are observed when there are no other differences:
So I think I made it clear that this corner case has not been mitigated properly.
This is my first PR, so please tell me if there's anything I can improve...
Thanks!