Skip to content

Commit dab5ed3

Browse files
dtolnaydtolnay
authored
Merge pull request #895 from dtolnay/ref
Eliminate all use of ref keyword
2 parents 45f1c4a + 05e03ee commit dab5ed3

File tree

8 files changed

+108
-119
lines changed

8 files changed

+108
-119
lines changed

‎src/error.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,9 @@ impl Error {
284284

285285
impl Display for ErrorCode {
286286
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
287-
match *self {
288-
ErrorCode::Message(ref msg) => f.write_str(msg),
289-
ErrorCode::Io(ref err) => Display::fmt(err, f),
287+
match self {
288+
ErrorCode::Message(msg) => f.write_str(msg),
289+
ErrorCode::Io(err) => Display::fmt(err, f),
290290
ErrorCode::EofWhileParsingList => f.write_str("EOF while parsing a list"),
291291
ErrorCode::EofWhileParsingObject => f.write_str("EOF while parsing an object"),
292292
ErrorCode::EofWhileParsingString => f.write_str("EOF while parsing a string"),
@@ -318,8 +318,8 @@ impl Display for ErrorCode {
318318
impl serde::de::StdError for Error {
319319
#[cfg(feature = "std")]
320320
fn source(&self) -> Option<&(dyn error::Error + 'static)> {
321-
match self.err.code {
322-
ErrorCode::Io(ref err) => Some(err),
321+
match &self.err.code {
322+
ErrorCode::Io(err) => Some(err),
323323
_ => None,
324324
}
325325
}

‎src/map.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -323,10 +323,10 @@ impl Eq for Map<String, Value> {}
323323
/// #
324324
/// # let val = &Value::String("".to_owned());
325325
/// # let _ =
326-
/// match *val {
327-
/// Value::String(ref s) => Some(s.as_str()),
328-
/// Value::Array(ref arr) => arr[0].as_str(),
329-
/// Value::Object(ref map) => map["type"].as_str(),
326+
/// match val {
327+
/// Value::String(s) => Some(s.as_str()),
328+
/// Value::Array(arr) => arr[0].as_str(),
329+
/// Value::Object(map) => map["type"].as_str(),
330330
/// _ => None,
331331
/// }
332332
/// # ;
@@ -530,9 +530,9 @@ impl<'a> Entry<'a> {
530530
/// assert_eq!(map.entry("serde").key(), &"serde");
531531
/// ```
532532
pub fn key(&self) -> &String {
533-
match *self {
534-
Entry::Vacant(ref e) => e.key(),
535-
Entry::Occupied(ref e) => e.key(),
533+
match self {
534+
Entry::Vacant(e) => e.key(),
535+
Entry::Occupied(e) => e.key(),
536536
}
537537
}
538538

‎src/read.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ where
252252
Some(ch) => {
253253
#[cfg(feature = "raw_value")]
254254
{
255-
if let Some(ref mut buf) = self.raw_buffer {
255+
if let Some(buf) = &mut self.raw_buffer {
256256
buf.push(ch);
257257
}
258258
}
@@ -263,7 +263,7 @@ where
263263
Some(Ok(ch)) => {
264264
#[cfg(feature = "raw_value")]
265265
{
266-
if let Some(ref mut buf) = self.raw_buffer {
266+
if let Some(buf) = &mut self.raw_buffer {
267267
buf.push(ch);
268268
}
269269
}
@@ -298,7 +298,7 @@ where
298298
#[cfg(feature = "raw_value")]
299299
fn discard(&mut self) {
300300
if let Some(ch) = self.ch.take() {
301-
if let Some(ref mut buf) = self.raw_buffer {
301+
if let Some(buf) = &mut self.raw_buffer {
302302
buf.push(ch);
303303
}
304304
}

‎src/ser.rs

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -533,11 +533,8 @@ where
533533
where
534534
T: ?Sized + Serialize,
535535
{
536-
match *self {
537-
Compound::Map {
538-
ref mut ser,
539-
ref mut state,
540-
} => {
536+
match self {
537+
Compound::Map { ser, state } => {
541538
tri!(ser
542539
.formatter
543540
.begin_array_value(&mut ser.writer, *state == State::First)
@@ -671,11 +668,8 @@ where
671668
where
672669
T: ?Sized + Serialize,
673670
{
674-
match *self {
675-
Compound::Map {
676-
ref mut ser,
677-
ref mut state,
678-
} => {
671+
match self {
672+
Compound::Map { ser, state } => {
679673
tri!(ser
680674
.formatter
681675
.begin_object_key(&mut ser.writer, *state == State::First)
@@ -702,8 +696,8 @@ where
702696
where
703697
T: ?Sized + Serialize,
704698
{
705-
match *self {
706-
Compound::Map { ref mut ser, .. } => {
699+
match self {
700+
Compound::Map { ser, .. } => {
707701
tri!(ser
708702
.formatter
709703
.begin_object_value(&mut ser.writer)
@@ -753,10 +747,10 @@ where
753747
where
754748
T: ?Sized + Serialize,
755749
{
756-
match *self {
750+
match self {
757751
Compound::Map { .. } => ser::SerializeMap::serialize_entry(self, key, value),
758752
#[cfg(feature = "arbitrary_precision")]
759-
Compound::Number { ref mut ser, .. } => {
753+
Compound::Number { ser, .. } => {
760754
if key == crate::number::TOKEN {
761755
tri!(value.serialize(NumberStrEmitter(ser)));
762756
Ok(())
@@ -765,7 +759,7 @@ where
765759
}
766760
}
767761
#[cfg(feature = "raw_value")]
768-
Compound::RawValue { ref mut ser, .. } => {
762+
Compound::RawValue { ser, .. } => {
769763
if key == crate::raw::TOKEN {
770764
tri!(value.serialize(RawValueStrEmitter(ser)));
771765
Ok(())

‎src/value/de.rs

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -648,8 +648,8 @@ macro_rules! deserialize_value_ref_number {
648648
where
649649
V: Visitor<'de>,
650650
{
651-
match *self {
652-
Value::Number(ref n) => n.deserialize_any(visitor),
651+
match self {
652+
Value::Number(n) => n.deserialize_any(visitor),
653653
_ => Err(self.invalid_type(&visitor)),
654654
}
655655
}
@@ -659,8 +659,8 @@ macro_rules! deserialize_value_ref_number {
659659
where
660660
V: Visitor<'de>,
661661
{
662-
match *self {
663-
Value::Number(ref n) => n.$method(visitor),
662+
match self {
663+
Value::Number(n) => n.$method(visitor),
664664
_ => self.deserialize_any(visitor),
665665
}
666666
}
@@ -710,13 +710,13 @@ impl<'de> serde::Deserializer<'de> for &'de Value {
710710
where
711711
V: Visitor<'de>,
712712
{
713-
match *self {
713+
match self {
714714
Value::Null => visitor.visit_unit(),
715-
Value::Bool(v) => visitor.visit_bool(v),
716-
Value::Number(ref n) => n.deserialize_any(visitor),
717-
Value::String(ref v) => visitor.visit_borrowed_str(v),
718-
Value::Array(ref v) => visit_array_ref(v, visitor),
719-
Value::Object(ref v) => visit_object_ref(v, visitor),
715+
Value::Bool(v) => visitor.visit_bool(*v),
716+
Value::Number(n) => n.deserialize_any(visitor),
717+
Value::String(v) => visitor.visit_borrowed_str(v),
718+
Value::Array(v) => visit_array_ref(v, visitor),
719+
Value::Object(v) => visit_object_ref(v, visitor),
720720
}
721721
}
722722

@@ -755,8 +755,8 @@ impl<'de> serde::Deserializer<'de> for &'de Value {
755755
where
756756
V: Visitor<'de>,
757757
{
758-
let (variant, value) = match *self {
759-
Value::Object(ref value) => {
758+
let (variant, value) = match self {
759+
Value::Object(value) => {
760760
let mut iter = value.into_iter();
761761
let (variant, value) = match iter.next() {
762762
Some(v) => v,
@@ -776,8 +776,8 @@ impl<'de> serde::Deserializer<'de> for &'de Value {
776776
}
777777
(variant, Some(value))
778778
}
779-
Value::String(ref variant) => (variant, None),
780-
ref other => {
779+
Value::String(variant) => (variant, None),
780+
other => {
781781
return Err(serde::de::Error::invalid_type(
782782
other.unexpected(),
783783
&"string or map",
@@ -831,8 +831,8 @@ impl<'de> serde::Deserializer<'de> for &'de Value {
831831
where
832832
V: Visitor<'de>,
833833
{
834-
match *self {
835-
Value::String(ref v) => visitor.visit_borrowed_str(v),
834+
match self {
835+
Value::String(v) => visitor.visit_borrowed_str(v),
836836
_ => Err(self.invalid_type(&visitor)),
837837
}
838838
}
@@ -848,9 +848,9 @@ impl<'de> serde::Deserializer<'de> for &'de Value {
848848
where
849849
V: Visitor<'de>,
850850
{
851-
match *self {
852-
Value::String(ref v) => visitor.visit_borrowed_str(v),
853-
Value::Array(ref v) => visit_array_ref(v, visitor),
851+
match self {
852+
Value::String(v) => visitor.visit_borrowed_str(v),
853+
Value::Array(v) => visit_array_ref(v, visitor),
854854
_ => Err(self.invalid_type(&visitor)),
855855
}
856856
}
@@ -883,8 +883,8 @@ impl<'de> serde::Deserializer<'de> for &'de Value {
883883
where
884884
V: Visitor<'de>,
885885
{
886-
match *self {
887-
Value::Array(ref v) => visit_array_ref(v, visitor),
886+
match self {
887+
Value::Array(v) => visit_array_ref(v, visitor),
888888
_ => Err(self.invalid_type(&visitor)),
889889
}
890890
}
@@ -912,8 +912,8 @@ impl<'de> serde::Deserializer<'de> for &'de Value {
912912
where
913913
V: Visitor<'de>,
914914
{
915-
match *self {
916-
Value::Object(ref v) => visit_object_ref(v, visitor),
915+
match self {
916+
Value::Object(v) => visit_object_ref(v, visitor),
917917
_ => Err(self.invalid_type(&visitor)),
918918
}
919919
}
@@ -927,9 +927,9 @@ impl<'de> serde::Deserializer<'de> for &'de Value {
927927
where
928928
V: Visitor<'de>,
929929
{
930-
match *self {
931-
Value::Array(ref v) => visit_array_ref(v, visitor),
932-
Value::Object(ref v) => visit_object_ref(v, visitor),
930+
match self {
931+
Value::Array(v) => visit_array_ref(v, visitor),
932+
Value::Object(v) => visit_object_ref(v, visitor),
933933
_ => Err(self.invalid_type(&visitor)),
934934
}
935935
}
@@ -1274,11 +1274,11 @@ impl Value {
12741274

12751275
#[cold]
12761276
fn unexpected(&self) -> Unexpected {
1277-
match *self {
1277+
match self {
12781278
Value::Null => Unexpected::Unit,
1279-
Value::Bool(b) => Unexpected::Bool(b),
1280-
Value::Number(ref n) => n.unexpected(),
1281-
Value::String(ref s) => Unexpected::Str(s),
1279+
Value::Bool(b) => Unexpected::Bool(*b),
1280+
Value::Number(n) => n.unexpected(),
1281+
Value::String(s) => Unexpected::Str(s),
12821282
Value::Array(_) => Unexpected::Seq,
12831283
Value::Object(_) => Unexpected::Map,
12841284
}

‎src/value/index.rs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,20 @@ pub trait Index: private::Sealed {
5353

5454
impl Index for usize {
5555
fn index_into<'v>(&self, v: &'v Value) -> Option<&'v Value> {
56-
match *v {
57-
Value::Array(ref vec) => vec.get(*self),
56+
match v {
57+
Value::Array(vec) => vec.get(*self),
5858
_ => None,
5959
}
6060
}
6161
fn index_into_mut<'v>(&self, v: &'v mut Value) -> Option<&'v mut Value> {
62-
match *v {
63-
Value::Array(ref mut vec) => vec.get_mut(*self),
62+
match v {
63+
Value::Array(vec) => vec.get_mut(*self),
6464
_ => None,
6565
}
6666
}
6767
fn index_or_insert<'v>(&self, v: &'v mut Value) -> &'v mut Value {
68-
match *v {
69-
Value::Array(ref mut vec) => {
68+
match v {
69+
Value::Array(vec) => {
7070
let len = vec.len();
7171
vec.get_mut(*self).unwrap_or_else(|| {
7272
panic!(
@@ -82,23 +82,23 @@ impl Index for usize {
8282

8383
impl Index for str {
8484
fn index_into<'v>(&self, v: &'v Value) -> Option<&'v Value> {
85-
match *v {
86-
Value::Object(ref map) => map.get(self),
85+
match v {
86+
Value::Object(map) => map.get(self),
8787
_ => None,
8888
}
8989
}
9090
fn index_into_mut<'v>(&self, v: &'v mut Value) -> Option<&'v mut Value> {
91-
match *v {
92-
Value::Object(ref mut map) => map.get_mut(self),
91+
match v {
92+
Value::Object(map) => map.get_mut(self),
9393
_ => None,
9494
}
9595
}
9696
fn index_or_insert<'v>(&self, v: &'v mut Value) -> &'v mut Value {
97-
if let Value::Null = *v {
97+
if let Value::Null = v {
9898
*v = Value::Object(Map::new());
9999
}
100-
match *v {
101-
Value::Object(ref mut map) => map.entry(self.to_owned()).or_insert(Value::Null),
100+
match v {
101+
Value::Object(map) => map.entry(self.to_owned()).or_insert(Value::Null),
102102
_ => panic!("cannot access key {:?} in JSON {}", self, Type(v)),
103103
}
104104
}

0 commit comments

Comments
 (0)