Skip to content

Commit 7906b96

Browse files
authored
fix(#131): wrong property name in RegisterRemovedColumns (#132)
1 parent 1dd8f13 commit 7906b96

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/Serilog.Ui.Core/Models/ColumnsInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ private static IEnumerable<string> RegisterRemovedColumns<T>()
6767
var isPropRemoved = propertiesProperty?.GetCustomAttribute<RemovedColumnAttribute>();
6868
if (isPropRemoved is not null)
6969
{
70-
yield return nameof(LogModel.Exception);
70+
yield return nameof(LogModel.Properties);
7171
}
7272
}
7373
}

tests/Serilog.Ui.Web.Tests/OptionsBuilder/SerilogUiOptionsBuilderTest.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,10 @@ public void It_creates_entries_in_additional_columns()
4242
var service = sut.Services.BuildServiceProvider().GetRequiredService<ProvidersOptions>();
4343
service.AdditionalColumns.Should().HaveCount(2);
4444
service.AdditionalColumns.Should().ContainKeys("test", "test2");
45-
service.AdditionalColumns.Values.Should().AllBeEquivalentTo(_columnsInfoSample);
45+
service.AdditionalColumns.Values.Should()
46+
.AllBeEquivalentTo(_columnsInfoSample)
47+
.And
48+
.AllSatisfy(s => s.RemovedColumns.Should().BeEquivalentTo([nameof(LogModel.Exception), nameof(LogModel.Properties)]));
4649
}
4750

4851
[Fact]
@@ -57,4 +60,4 @@ public void It_registers_options_in_services()
5760
}
5861

5962
private static SerilogUiOptionsBuilder GetBuilder() => new(new ServiceCollection());
60-
}
63+
}

0 commit comments

Comments
 (0)