Using string.IsNullOrEmpty / Adding extra comments

rsantosdev · rsantosdev · commit 4fea46555139 · 2020-04-30T20:27:50.000-03:00
diff --git a/src/Serilog.AspNetCore/AspNetCore/RequestLoggingMiddleware.cs b/src/Serilog.AspNetCore/AspNetCore/RequestLoggingMiddleware.cs
@@ -106,8 +106,13 @@ static double GetElapsedMilliseconds(long start, long stop)
 
         static string GetPath(HttpContext httpContext)
         {
+            /*
+                In some cases, like when running integration tests with WebApplicationFactory<T>
+                the RawTarget returns an empty string instead of null, in that case we can't use
+                ?? as fallback.
+            */
             var requestPath = httpContext.Features.Get<IHttpRequestFeature>()?.RawTarget;
-            if (string.IsNullOrWhiteSpace(requestPath))
+            if (string.IsNullOrEmpty(requestPath))
             {
                 requestPath = httpContext.Request.Path.ToString();
             }

Original file line number	Diff line number	Diff line change
`@@ -106,8 +106,13 @@ static double GetElapsedMilliseconds(long start, long stop)`
`106`	`106`
`107`	`107`	`static string GetPath(HttpContext httpContext)`
`108`	`108`	`{`
	`109`	`+ /*`
	`110`	`+ In some cases, like when running integration tests with WebApplicationFactory<T>`
	`111`	`+ the RawTarget returns an empty string instead of null, in that case we can't use`
	`112`	`+ ?? as fallback.`
	`113`	`+ */`
`109`	`114`	`var requestPath = httpContext.Features.Get<IHttpRequestFeature>()?.RawTarget;`
`110`		`- if (string.IsNullOrWhiteSpace(requestPath))`
	`115`	`+ if (string.IsNullOrEmpty(requestPath))`
`111`	`116`	`{`
`112`	`117`	`requestPath = httpContext.Request.Path.ToString();`
`113`	`118`	`}`