Merge pull request #74 from snoozbuster/dev

Added support for abstract classes

Author: nblumhardt

src/Serilog.Settings.Configuration/Settings/Configuration/StringArgumentValue.cs

@@ -54,7 +54,7 @@ public object ConvertTo(Type toType)
             if (convertor != null)
                 return convertor(argumentValue);
 
-            if (toTypeInfo.IsInterface && !string.IsNullOrWhiteSpace(argumentValue))
+            if ((toTypeInfo.IsInterface || toTypeInfo.IsAbstract) && !string.IsNullOrWhiteSpace(argumentValue))
             {
                 var type = Type.GetType(argumentValue.Trim());
                 if (type != null)

test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs

@@ -1,5 +1,6 @@
 using Serilog.Formatting;
 using Serilog.Formatting.Json;
+using Serilog.Settings.Configuration.Tests.Support;
 using Xunit;
 
 namespace Serilog.Settings.Configuration.Tests
@@ -15,5 +16,15 @@ public void StringValuesConvertToDefaultInstancesIfTargetIsInterface()
 
             Assert.IsType<JsonFormatter>(result);
         }
-    }
+
+        [Fact]
+        public void StringValuesConvertToDefaultInstancesIfTargetIsAbstractClass()
+        {
+          var stringArgumentValue = new StringArgumentValue(() => "Serilog.Settings.Configuration.Tests.Support.ConcreteClass, Serilog.Settings.Configuration.Tests");
+
+          var result = stringArgumentValue.ConvertTo(typeof(AbstractClass));
+
+          Assert.IsType<ConcreteClass>(result);
+        }
+  }
 }

test/Serilog.Settings.Configuration.Tests/Support/AbstractClass.cs

@@ -0,0 +1,6 @@
+namespace Serilog.Settings.Configuration.Tests.Support
+{
+    public abstract class AbstractClass { }
+
+    public class ConcreteClass : AbstractClass { }
+}