Skip to content

Commit bd779e5

Browse files
author
Sergey Komisarchik
authored
Merge pull request #219 from skomis-mm/reduceGraph
Reduce search graph for auto discovery
2 parents 8bea591 + a1d539a commit bd779e5

File tree

7 files changed

+36
-34
lines changed

7 files changed

+36
-34
lines changed

.travis.yml

Lines changed: 0 additions & 11 deletions
This file was deleted.

Build.ps1

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ foreach ($src in dir src/*) {
2020

2121
echo "build: Packaging project in $src"
2222

23-
& dotnet pack -c Release -o ..\..\artifacts --version-suffix=$suffix
23+
& dotnet pack -c Release -o ..\..\artifacts --version-suffix=$suffix -p:ContinuousIntegrationBuild=true
2424
if ($LASTEXITCODE -ne 0) { exit 1 }
2525

2626
Pop-Location
@@ -42,10 +42,25 @@ foreach ($test in dir test/*.Tests) {
4242

4343
echo "build: Testing project in $test"
4444

45-
& dotnet test -c Release
45+
if ($PSVersionTable.Platform -eq "Unix") {
46+
& dotnet test -c Release -f netcoreapp2.0
47+
& dotnet test -c Release -f netcoreapp3.1
48+
} else {
49+
& dotnet test -c Release
50+
}
51+
4652
if ($LASTEXITCODE -ne 0) { exit 3 }
4753

4854
Pop-Location
4955
}
5056

57+
if ($PSVersionTable.Platform -eq "Unix") {
58+
Push-Location sample/Sample
59+
60+
& dotnet run -f netcoreapp2.0 -c Release --run-once
61+
if ($LASTEXITCODE -ne 0) { exit 4 }
62+
63+
Pop-Location
64+
}
65+
5166
Pop-Location

appveyor.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,18 @@
11
version: '{build}'
22
skip_tags: true
3-
image: Visual Studio 2019
3+
image:
4+
- Visual Studio 2019
5+
- Ubuntu1604
46
configuration: Release
57
build_script:
68
- ps: ./Build.ps1
9+
for:
10+
-
11+
matrix:
12+
only:
13+
- image: Ubuntu1604
14+
build_script:
15+
- pwsh ./Build.ps1
716
test: off
817
artifacts:
918
- path: artifacts/Serilog.*.nupkg
@@ -12,7 +21,6 @@ deploy:
1221
- provider: NuGet
1322
api_key:
1423
secure: b7jxRe5kR3kuxMrmdDuN0jvaaWWHwtFRnAwFZZV6MdaorwUhASR/Ey1gPn6vXwND
15-
skip_symbols: true
1624
on:
1725
branch: /^(master|dev)$/
1826
- provider: GitHub

build.sh

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/Serilog.Settings.Configuration/Serilog.Settings.Configuration.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<PackageId>Serilog.Settings.Configuration</PackageId>
1616
<PackageTags>serilog;json</PackageTags>
1717
<PackageIcon>icon.png</PackageIcon>
18-
<PackageProjectUrl>https://serilog.net/</PackageProjectUrl>
18+
<PackageProjectUrl>https://github.com/serilog/serilog-settings-configuration/</PackageProjectUrl>
1919
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
2020
<RootNamespace>Serilog</RootNamespace>
2121
<PublishRepositoryUrl>true</PublishRepositoryUrl>

src/Serilog.Settings.Configuration/Settings/Configuration/Assemblies/DependencyContextAssemblyFinder.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,17 @@ public DependencyContextAssemblyFinder(DependencyContext dependencyContext)
1818
public override IReadOnlyList<AssemblyName> FindAssembliesContainingName(string nameToFind)
1919
{
2020
var query = from library in _dependencyContext.RuntimeLibraries
21+
where IsReferencingSerilog(library)
2122
from assemblyName in library.GetDefaultAssemblyNames(_dependencyContext)
2223
where IsCaseInsensitiveMatch(assemblyName.Name, nameToFind)
2324
select assemblyName;
2425

2526
return query.ToList().AsReadOnly();
27+
28+
static bool IsReferencingSerilog(Library library)
29+
{
30+
return library.Dependencies.Any(dependency => dependency.Name.Equals("serilog", StringComparison.OrdinalIgnoreCase));
31+
}
2632
}
2733
}
2834
}

src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReader.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,8 @@ internal static IConfigurationArgumentValue GetArgumentValue(IConfigurationSecti
264264

265265
static IReadOnlyCollection<Assembly> LoadConfigurationAssemblies(IConfigurationSection section, AssemblyFinder assemblyFinder)
266266
{
267-
var assemblies = new Dictionary<string, Assembly>();
267+
var serilogAssembly = typeof(ILogger).Assembly;
268+
var assemblies = new Dictionary<string, Assembly> { [serilogAssembly.FullName] = serilogAssembly };
268269

269270
var usingSection = section.GetSection("Using");
270271
if (usingSection.GetChildren().Any())

0 commit comments

Comments
 (0)