Skip to content

Commit cf2bb1b

Browse files
author
Sergey Komisarchik
committed
DllScanningAssemblyFinderTests
- extract strings to constants
1 parent 297a132 commit cf2bb1b

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

test/Serilog.Settings.Configuration.Tests/DllScanningAssemblyFinderTests.cs

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,17 @@ namespace Serilog.Settings.Configuration.Tests
99
{
1010
public class DllScanningAssemblyFinderTests : IDisposable
1111
{
12+
const string BinDir1 = "bin1";
13+
const string BinDir2 = "bin2";
14+
const string BinDir3 = "bin3";
15+
1216
readonly string _privateBinPath;
1317

1418
public DllScanningAssemblyFinderTests()
1519
{
16-
var d1 = GetOrCreateDirectory("bin1");
17-
var d2 = GetOrCreateDirectory("bin2");
18-
var d3 = GetOrCreateDirectory("bin3");
20+
var d1 = GetOrCreateDirectory(BinDir1);
21+
var d2 = GetOrCreateDirectory(BinDir2);
22+
var d3 = GetOrCreateDirectory(BinDir3);
1923

2024
_privateBinPath = $"{d1.Name};{d2.FullName};{d3.Name}";
2125

@@ -25,9 +29,9 @@ DirectoryInfo GetOrCreateDirectory(string name)
2529

2630
public void Dispose()
2731
{
28-
Directory.Delete("bin1", true);
29-
Directory.Delete("bin2", true);
30-
Directory.Delete("bin3", true);
32+
Directory.Delete(BinDir1, true);
33+
Directory.Delete(BinDir2, true);
34+
Directory.Delete(BinDir3, true);
3135
}
3236

3337
[Fact]
@@ -41,9 +45,9 @@ public void ShouldProbeCurrentDirectory()
4145
[Fact]
4246
public void ShouldProbePrivateBinPath()
4347
{
44-
File.Copy("testdummies.dll", "bin1/customSink1.dll", true);
45-
File.Copy("testdummies.dll", "bin2/customSink2.dll", true);
46-
File.Copy("testdummies.dll", "bin3/thirdpartydependency.dll", true);
48+
File.Copy("testdummies.dll", $"{BinDir1}/customSink1.dll", true);
49+
File.Copy("testdummies.dll", $"{BinDir2}/customSink2.dll", true);
50+
File.Copy("testdummies.dll", $"{BinDir3}/thirdpartydependency.dll", true);
4751

4852
var ad = AppDomain.CreateDomain("serilog", null,
4953
new AppDomainSetup

0 commit comments

Comments
 (0)