Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

Commit 4428d5c

Browse files
authored
fix(serverless-component): when adding primary domain name to CloudFront distribution aliases, don't replace other aliases (#658)
1 parent 1f2d153 commit 4428d5c

File tree

1 file changed

+7
-9
lines changed
  • packages/serverless-components/domain

1 file changed

+7
-9
lines changed

packages/serverless-components/domain/utils.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -393,21 +393,19 @@ const addDomainToCloudfrontDistribution = async (
393393
params.Id = subdomain.distributionId;
394394

395395
// 5. then make our changes
396-
params.DistributionConfig.Aliases = {
397-
Quantity: 1,
398-
Items: [subdomain.domain]
399-
};
400-
396+
params.DistributionConfig.Aliases.Items.push(subdomain.domain);
397+
params.DistributionConfig.Aliases.Quantity += 1;
401398
if (subdomain.domain.startsWith("www.")) {
402399
if (domainType === "apex") {
403-
params.DistributionConfig.Aliases.Items = [
404-
`${subdomain.domain.replace("www.", "")}`
405-
];
400+
params.DistributionConfig.Aliases.Items[-1] = `${subdomain.domain.replace(
401+
"www.",
402+
""
403+
)}`;
406404
} else if (domainType !== "www") {
407-
params.DistributionConfig.Aliases.Quantity = 2;
408405
params.DistributionConfig.Aliases.Items.push(
409406
`${subdomain.domain.replace("www.", "")}`
410407
);
408+
params.DistributionConfig.Aliases.Quantity += 1;
411409
}
412410
}
413411

0 commit comments

Comments
 (0)