Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

Commit 52b902f

Browse files
authored
feat(nextjs-component): update default runtime to nodejs14.x (#1301)
1 parent dfc76a5 commit 52b902f

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

packages/serverless-components/nextjs-component/__tests__/custom-inputs.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -525,12 +525,12 @@ describe("Custom inputs", () => {
525525

526526
describe.each`
527527
inputRuntime | expectedRuntime
528-
${undefined} | ${{ defaultRuntime: "nodejs12.x", apiRuntime: "nodejs12.x" }}
529-
${{}} | ${{ defaultRuntime: "nodejs12.x", apiRuntime: "nodejs12.x" }}
530-
${"nodejs10.x"} | ${{ defaultRuntime: "nodejs10.x", apiRuntime: "nodejs10.x" }}
531-
${{ defaultLambda: "nodejs10.x" }} | ${{ defaultRuntime: "nodejs10.x", apiRuntime: "nodejs12.x" }}
532-
${{ apiLambda: "nodejs10.x" }} | ${{ defaultRuntime: "nodejs12.x", apiRuntime: "nodejs10.x" }}
533-
${{ defaultLambda: "nodejs10.x", apiLambda: "nodejs10.x" }} | ${{ defaultRuntime: "nodejs10.x", apiRuntime: "nodejs10.x" }}
528+
${undefined} | ${{ defaultRuntime: "nodejs14.x", apiRuntime: "nodejs14.x" }}
529+
${{}} | ${{ defaultRuntime: "nodejs14.x", apiRuntime: "nodejs14.x" }}
530+
${"nodejs12.x"} | ${{ defaultRuntime: "nodejs12.x", apiRuntime: "nodejs12.x" }}
531+
${{ defaultLambda: "nodejs12.x" }} | ${{ defaultRuntime: "nodejs12.x", apiRuntime: "nodejs14.x" }}
532+
${{ apiLambda: "nodejs12.x" }} | ${{ defaultRuntime: "nodejs14.x", apiRuntime: "nodejs12.x" }}
533+
${{ defaultLambda: "nodejs12.x", apiLambda: "nodejs12.x" }} | ${{ defaultRuntime: "nodejs12.x", apiRuntime: "nodejs12.x" }}
534534
`("Input runtime options", ({ inputRuntime, expectedRuntime }) => {
535535
let tmpCwd: string;
536536
const fixturePath = path.join(__dirname, "./fixtures/generic-fixture");

packages/serverless-components/nextjs-component/__tests__/deploy.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ describe.each`
121121
code: path.join(fixturePath, REGENERATION_LAMBDA_CODE_DIR),
122122
memory: 512,
123123
timeout: 10,
124-
runtime: "nodejs12.x",
124+
runtime: "nodejs14.x",
125125
name: "bucket-xyz",
126126
region: "us-east-1",
127127
tags: undefined,
@@ -175,7 +175,7 @@ describe.each`
175175
code: path.join(fixturePath, DEFAULT_LAMBDA_CODE_DIR),
176176
memory: 512,
177177
timeout: 10,
178-
runtime: "nodejs12.x",
178+
runtime: "nodejs14.x",
179179
tags: undefined,
180180
role: {
181181
service: ["lambda.amazonaws.com", "edgelambda.amazonaws.com"],
@@ -222,7 +222,7 @@ describe.each`
222222
code: path.join(fixturePath, API_LAMBDA_CODE_DIR),
223223
memory: 512,
224224
timeout: 10,
225-
runtime: "nodejs12.x",
225+
runtime: "nodejs14.x",
226226
tags: undefined,
227227
role: {
228228
service: ["lambda.amazonaws.com", "edgelambda.amazonaws.com"],
@@ -269,7 +269,7 @@ describe.each`
269269
code: path.join(fixturePath, IMAGE_LAMBDA_CODE_DIR),
270270
memory: 512,
271271
timeout: 10,
272-
runtime: "nodejs12.x",
272+
runtime: "nodejs14.x",
273273
tags: undefined,
274274
role: {
275275
service: ["lambda.amazonaws.com", "edgelambda.amazonaws.com"],

packages/serverless-components/nextjs-component/src/component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ class NextjsComponent extends Component {
569569
runtime: readLambdaInputValue(
570570
"runtime",
571571
"regenerationLambda",
572-
"nodejs12.x"
572+
"nodejs14.x"
573573
) as string,
574574
name: bucketOutputs.name,
575575
tags: readLambdaInputValue(
@@ -611,7 +611,7 @@ class NextjsComponent extends Component {
611611
runtime: readLambdaInputValue(
612612
"runtime",
613613
"apiLambda",
614-
"nodejs12.x"
614+
"nodejs14.x"
615615
) as string,
616616
name: readLambdaInputValue("name", "apiLambda", undefined) as
617617
| string
@@ -672,7 +672,7 @@ class NextjsComponent extends Component {
672672
runtime: readLambdaInputValue(
673673
"runtime",
674674
"imageLambda",
675-
"nodejs12.x"
675+
"nodejs14.x"
676676
) as string,
677677
name: readLambdaInputValue("name", "imageLambda", undefined) as
678678
| string
@@ -737,7 +737,7 @@ class NextjsComponent extends Component {
737737
runtime: readLambdaInputValue(
738738
"runtime",
739739
"defaultLambda",
740-
"nodejs12.x"
740+
"nodejs14.x"
741741
) as string,
742742
name: readLambdaInputValue("name", "defaultLambda", undefined) as
743743
| string

0 commit comments

Comments
 (0)