feat(lambda-at-edge-compat,lambda-at-edge,nextjs-component): disable

manual lambda at edge compression

Author: danielcondemarin

packages/compat-layers/lambda-at-edge-compat/next-aws-cloudfront.d.ts

@@ -1,9 +1,16 @@
 import { CloudFrontResultResponse, CloudFrontRequest } from "aws-lambda";
 import { IncomingMessage, ServerResponse } from "http";
 
-declare function lambdaAtEdgeCompat(event: {
-  request: CloudFrontRequest;
-}): {
+type CompatOptions = {
+  enableHTTPCompression: boolean;
+};
+
+declare function lambdaAtEdgeCompat(
+  event: {
+    request: CloudFrontRequest;
+  },
+  options: CompatOptions
+): {
   responsePromise: Promise<CloudFrontResultResponse>;
   req: IncomingMessage;
   res: ServerResponse;

packages/compat-layers/lambda-at-edge-compat/next-aws-cloudfront.js

@@ -144,7 +144,7 @@ const isGzipSupported = (headers) => {
   return gz;
 };
 
-const handler = (event) => {
+const handler = (event, { enableHTTPCompression }) => {
   const { request: cfRequest, response: cfResponse = { headers: {} } } = event;
 
   const response = {
@@ -227,7 +227,7 @@ const handler = (event) => {
     ]);
   };
 
-  let gz = isGzipSupported(headers);
+  let shouldGzip = enableHTTPCompression && isGzipSupported(headers);
 
   const responsePromise = new Promise((resolve) => {
     res.end = (text) => {
@@ -245,14 +245,14 @@ const handler = (event) => {
 
       if (response.body) {
         response.bodyEncoding = "base64";
-        response.body = gz
+        response.body = shouldGzip
           ? zlib.gzipSync(response.body).toString("base64")
           : Buffer.from(response.body).toString("base64");
       }
 
       response.headers = toCloudFrontHeaders(res.headers, cfResponse.headers);
 
-      if (gz) {
+      if (shouldGzip) {
         response.headers["content-encoding"] = [
           { key: "Content-Encoding", value: "gzip" }
         ];

packages/libs/lambda-at-edge/src/api-handler.ts

@@ -8,7 +8,7 @@ import {
   OriginRequestEvent,
   RoutesManifest
 } from "../types";
-import { CloudFrontResultResponse, CloudFrontRequest } from "aws-lambda";
+import { CloudFrontResultResponse } from "aws-lambda";
 import {
   createRedirectResponse,
   getDomainRedirectPath,
@@ -92,7 +92,9 @@ export const handler = async (
 
   // eslint-disable-next-line
   const page = require(`./${pagePath}`);
-  const { req, res, responsePromise } = cloudFrontCompat(event.Records[0].cf);
+  const { req, res, responsePromise } = cloudFrontCompat(event.Records[0].cf, {
+    enableHTTPCompression: buildManifest.enableHTTPCompression
+  });
 
   page.default(req, res);
 

packages/libs/lambda-at-edge/src/build.ts

@@ -30,6 +30,7 @@ type BuildOptions = {
   logLambdaExecutionTimes?: boolean;
   domainRedirects?: { [key: string]: string };
   minifyHandlers?: boolean;
+  enableHTTPCompression?: boolean;
 };
 
 const defaultBuildOptions = {
@@ -40,7 +41,8 @@ const defaultBuildOptions = {
   useServerlessTraceTarget: false,
   logLambdaExecutionTimes: false,
   domainRedirects: {},
-  minifyHandlers: false
+  minifyHandlers: false,
+  enableHTTPCompression: true
 };
 
 class Builder {
@@ -357,7 +359,8 @@ class Builder {
     );
     const {
       logLambdaExecutionTimes = false,
-      domainRedirects = {}
+      domainRedirects = {},
+      enableHTTPCompression = false
     } = this.buildOptions;
 
     this.normalizeDomainRedirects(domainRedirects);
@@ -377,15 +380,17 @@ class Builder {
       },
       publicFiles: {},
       trailingSlash: false,
-      domainRedirects: domainRedirects
+      domainRedirects: domainRedirects,
+      enableHTTPCompression
     };
 
     const apiBuildManifest: OriginRequestApiHandlerManifest = {
       apis: {
         dynamic: {},
         nonDynamic: {}
       },
-      domainRedirects: domainRedirects
+      domainRedirects: domainRedirects,
+      enableHTTPCompression
     };
 
     const ssrPages = defaultBuildManifest.pages.ssr;

packages/libs/lambda-at-edge/src/default-handler.ts

@@ -375,7 +375,12 @@ const handleOriginRequest = async ({
   log("require JS execution time", tBeforePageRequire, tAfterPageRequire);
 
   const tBeforeSSR = now();
-  const { req, res, responsePromise } = lambdaAtEdgeCompat(event.Records[0].cf);
+  const { req, res, responsePromise } = lambdaAtEdgeCompat(
+    event.Records[0].cf,
+    {
+      enableHTTPCompression: manifest.enableHTTPCompression
+    }
+  );
   try {
     // If page is _error.js, set status to 404 so _error.js will render a 404 page
     if (pagePath === "pages/_error.js") {
@@ -454,7 +459,10 @@ const handleOriginResponse = async ({
     // eslint-disable-next-line
     const page = require(`./${pagePath}`);
     const { req, res, responsePromise } = lambdaAtEdgeCompat(
-      event.Records[0].cf
+      event.Records[0].cf,
+      {
+        enableHTTPCompression: manifest.enableHTTPCompression
+      }
     );
     const isSSG = !!page.getStaticProps;
     const { renderOpts, html } = await page.renderReqToHTML(

packages/libs/lambda-at-edge/types.d.ts

@@ -21,6 +21,7 @@ export type OriginRequestApiHandlerManifest = {
   domainRedirects: {
     [key: string]: string;
   };
+  enableHTTPCompression: boolean;
 };
 
 export type OriginRequestDefaultHandlerManifest = {
@@ -44,6 +45,7 @@ export type OriginRequestDefaultHandlerManifest = {
     [key: string]: string;
   };
   trailingSlash: boolean;
+  enableHTTPCompression: boolean;
   domainRedirects: {
     [key: string]: string;
   };

packages/serverless-components/nextjs-component/src/component.ts

@@ -187,7 +187,8 @@ class NextjsComponent extends Component {
           useServerlessTraceTarget: inputs.useServerlessTraceTarget || false,
           logLambdaExecutionTimes: inputs.logLambdaExecutionTimes || false,
           domainRedirects: inputs.domainRedirects || {},
-          minifyHandlers: inputs.minifyHandlers || false
+          minifyHandlers: inputs.minifyHandlers || false,
+          enableHTTPCompression: false
         }
       );