Skip to content

Commit 41cc7da

Browse files
authored
chore: rename test scripts & test compat pkg in CI (SAP#6246)
+ Fix import error & adjust Dev Guidelines docs
1 parent 4fb6008 commit 41cc7da

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ jobs:
2020
- cypress-commands
2121
- main/src/components
2222
- main/src/internal
23+
- compat
2324
react: ['18', '19']
2425
fail-fast: false
2526
steps:

docs/Guidelines.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
## Requirements
44

55
- [Yarn](https://yarnpkg.com)
6-
- [Node.js](https://nodejs.org/) (**version 14 or higher** ⚠️)
6+
- [Node.js](https://nodejs.org/) (**[LTS](https://github.com/nodejs/release?tab=readme-ov-file#release-schedule) version** ⚠️)
77

88
## Setup your local development environment
99

10-
Please make sure you have installed `node` 14 or higher (check by running `node -v`) and yarn v1 (check by running `yarn -v`).
10+
Please make sure you have installed a [LTS](https://github.com/nodejs/release?tab=readme-ov-file#release-schedule) `node` version (check by running `node -v`) and yarn v1 (check by running `yarn -v`).
1111

1212
First, you need to clone the git repository by running
1313

@@ -22,7 +22,7 @@ Then, go into that cloned directory and run `yarn install`. At this point, you a
2222
This starts the local storybook, so you can check if your components are rendered correctly. _If the storybook doesn't open automatically after executing the command, you can use this link: http://localhost:6006/_
2323
- `yarn test` <br />
2424
This command is running all tests in the project.
25-
- `yarn test:cypress:open` <br />
25+
- `yarn test:open` <br />
2626
This command is opening all cypress tests in Chrome.
2727
- `yarn build` <br />
2828
This command executes the full build of the project.

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@
1414
"build:storybook": "lerna run build:i18n && yarn create-cypress-commands-docs && storybook build -o .out",
1515
"build:storybook-sitemap": "node ./scripts/create-storybook-sitemap.js --directory .out",
1616
"test:prepare": "rimraf temp && lerna run build",
17-
"test:cypress": "cypress run --component --browser chrome",
18-
"test:cypress:open": "CYPRESS_COVERAGE=false cypress open --component --browser chrome",
19-
"test": "yarn test:prepare && yarn test:cypress",
17+
"test:open": "CYPRESS_COVERAGE=false cypress open --component --browser firefox",
18+
"test": "yarn test:prepare && cypress run --component --browser chrome",
2019
"clean": "tsc --build --clean && tsc --build tsconfig.build.json --clean && rimraf temp .out && lerna run clean",
2120
"clean:remove-modules": "yarn clean && rimraf node_modules",
2221
"prettier:all": "prettier --write --config ./prettier.config.cjs \"packages/**/*.{js,jsx,ts,tsx,mdx,json,md}\"",

packages/compat/src/components/Loader/Loader.cy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { LoaderType } from '../../enums/index.js';
1+
import { LoaderType } from '../../enums/LoaderType.js';
22
import { Loader } from './index.js';
33
import { cypressPassThroughTestsFactory } from '@/cypress/support/utils';
44

0 commit comments

Comments
 (0)