Merge pull request #11 from pcwalton/node-is-link

metajack · metajack · commit 7a59bc7f27a2 · 2013-05-29T23:42:08.000-07:00
Add node_is_link
diff --git a/select.rs b/select.rs
@@ -91,6 +91,7 @@ pub trait SelectHandler<N> {
     fn node_has_id(&self, node: &N, &str) -> bool;
     fn named_ancestor_node(&self, node: &N, name: &str) -> Option<N>;
     fn node_is_root(&self, node: &N) -> bool;
+    fn node_is_link(&self, node: &N) -> bool;
 }
 
 /** Used to convert the netsurfcss CssSelectHandler callbacks to out SelectHandler callbacks */
@@ -138,10 +139,8 @@ impl<N, H: SelectHandler<N>> n::s::CssSelectHandler<N> for SelectHandlerWrapper<
         self.inner_ref().node_is_root(node)
     }
 
-    fn node_is_link(&self, _node: &N) -> bool {
-        // FIXME
-        warn_unimpl("node_is_link");
-        false
+    fn node_is_link(&self, node: &N) -> bool {
+        self.inner_ref().node_is_link(node)
     }
 
     fn node_is_visited(&self, _node: &N) -> bool {

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,7 @@ pub trait SelectHandler<N> {`
`91`	`91`	`fn node_has_id(&self, node: &N, &str) -> bool;`
`92`	`92`	`fn named_ancestor_node(&self, node: &N, name: &str) -> Option<N>;`
`93`	`93`	`fn node_is_root(&self, node: &N) -> bool;`
	`94`	`+ fn node_is_link(&self, node: &N) -> bool;`
`94`	`95`	`}`
`95`	`96`
`96`	`97`	`/** Used to convert the netsurfcss CssSelectHandler callbacks to out SelectHandler callbacks */`
`@@ -138,10 +139,8 @@ impl<N, H: SelectHandler<N>> n::s::CssSelectHandler<N> for SelectHandlerWrapper<`
`138`	`139`	`self.inner_ref().node_is_root(node)`
`139`	`140`	`}`
`140`	`141`
`141`		`- fn node_is_link(&self, _node: &N) -> bool {`
`142`		`- // FIXME`
`143`		`- warn_unimpl("node_is_link");`
`144`		`- false`
	`142`	`+ fn node_is_link(&self, node: &N) -> bool {`
	`143`	`+ self.inner_ref().node_is_link(node)`
`145`	`144`	`}`
`146`	`145`
`147`	`146`	`fn node_is_visited(&self, _node: &N) -> bool {`