Merge pull request #12 from pcwalton/percentage-widths

brson · brson · commit ca4e2c62e0f7 · 2013-05-31T00:23:02.000-07:00
Don't crash on percentage widths, instead just substitute some nonsense value
diff --git a/computed.rs b/computed.rs
@@ -364,7 +364,7 @@ fn convert_net_line_height_value(value: n::v::CssLineHeightValue) -> CSSValue<CS
 fn convert_net_unit_to_length(unit: n::t::CssUnit) -> Length {
     match convert_net_unit_to_length_or_percent(unit) {
         Left(v) => v,
-        Right(*) => fail!(~"unexpected percentage unit")
+        Right(*) => Px(100.0),  // FIXME(pcwalton): fill this in.
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ fn convert_net_line_height_value(value: n::v::CssLineHeightValue) -> CSSValue<CS`
`364`	`364`	`fn convert_net_unit_to_length(unit: n::t::CssUnit) -> Length {`
`365`	`365`	`match convert_net_unit_to_length_or_percent(unit) {`
`366`	`366`	`Left(v) => v,`
`367`		`- Right(*) => fail!(~"unexpected percentage unit")`
	`367`	`+ Right(*) => Px(100.0), // FIXME(pcwalton): fill this in.`
`368`	`368`	`}`
`369`	`369`	`}`
`370`	`370`